Passing invalid column names to selectBy doesn't break

[Julian Edwards]

For the SQLObject compatibility layer - if I pass a bogus column name as one of the args to selectBy it just returns an empty result set. I'd really expect it to throw an exception so we can catch typos.

[James Henstridge (jamesh)]

The keyword arguments to selectBy() are converted to the where clause with:

        for key, value in self._by.items():
            args.append(getattr(self._cls, key) == value)

So you should get an AttributeError if you make a typo, unless the incorrect attribute name actually exists on the class. Perhaps that is what you observed?

[Julian Edwards (julian-edwards)]

On Tuesday 04 January 2011 10:02:34 you wrote:
> The keyword arguments to selectBy() are converted to the where clause
> with:
>
>
> for key, value in self._by.items():
> args.append(getattr(self._cls, key) == value)
>
> So you should get an AttributeError if you make a typo, unless the
> incorrect attribute name actually exists on the class. Perhaps that is
> what you observed?

I don't remember exactly what the args were now, sorry :/

It's still a bug though, isn't it? The 'getattr' should surely be something
that looks up column names instead.