Provide some way to do "SELECT ... FOR UPDATE"

Bug #499363 reported by James Henstridge
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Storm
New
Undecided
Unassigned

Bug Description

It would be nice if Storm provided a way to issue "SELECT ... FOR UPDATE" queries as a way to acquire write locks on particular rows in a table.

I'd imagine the primary entry points where a user might want to do this is in Store.get() and a similar ResultSet API. I am not quite sure what the API should look like though.

Tags: review

Related branches

Revision history for this message
Edoardo Serra (edoardo-serra) wrote :

I started implementing this feature in the linked branch.

I've been using Storm for a while but I started looking at its code a few days ago, so feel free to criticise my design and implementation!

I implemented the feature as a method of the ResultSet which seemed to me to be the correct place.
I'm also considering to implement the feature in Store.get(), will follow in the next days.

Since I have some issues on running tests on my machine I did not commit them yet.

My 2 cents

Revision history for this message
Edoardo Serra (edoardo-serra) wrote :

I implemented the feature in Store.get() and wrote the unit tests.

I think the branch is now ready to be reviewed.

Hope it hepls

tags: added: review
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.