InterfaceError: connection already closed should be converted into DisconnectionError

Reported by Francis J. Lacoste on 2009-05-11
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Storm
High
James Henstridge

Bug Description

Like bug 360846 showed it's possible for disconnection error to go unnoticed and leave the connection in a irrecuperable state. When the connection is in this state, psycopg2 will raise an InterfaceError: connection already closed error, these should be recognized as disconnection error and converted to the appropriate exception.

Related branches

lp:~jamesh/storm/bug-374909
Stuart Bishop: Approve on 2009-07-01
Thomas Herve: Approve on 2009-06-19
lp:~salgado/storm/bug-374909
James Henstridge: Approve on 2009-07-30
Jamu Kakar: Approve on 2009-07-28
James Henstridge (jamesh) wrote :

This is affecting U1 too (the Django integration bypasses Storm's disconnection checking, so it is possible for this error to occur).

Changed in storm:
assignee: nobody → James Henstridge (jamesh)
importance: Undecided → High
status: New → Triaged
milestone: none → 0.15
Changed in storm:
status: Triaged → In Progress
Thomas Herve (therve) wrote :

This bug is fixed now?

James Henstridge (jamesh) wrote :

Fix merged in r308.

Changed in storm:
status: In Progress → Fix Committed
Changed in storm:
status: Fix Committed → Triaged
Guilherme Salgado (salgado) wrote :

Connection.rollback() doesn't consider InterfaceError a form of disconnection error as it was meant to do.
I have a fix for that at lp:~salgado/storm/bug-374909, and I'd appreciate if someone could have a look.

James Henstridge (jamesh) wrote :

That branch has also been reviewed and merged now as r319.

Changed in storm:
status: Triaged → Fix Committed
Jamu Kakar (jkakar) on 2009-08-08
Changed in storm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers