It should be possible to create queries with 'FROM table1 USING table2' syntax

[Jamu Kakar]

I don't know if this is standard SQL, but PostgreSQL supports it.

[James Henstridge (jamesh)]

Could you make the branch attached to this bug public?

[Jamu Kakar (jkakar)]

Oops, it's public now, sorry about that.

[James Henstridge (jamesh)]

Thanks for making the branch public. It looks like one of your team memberships causes all your Storm branches to be private by default, so it might be worth checking if there is anything else that was meant to be public.

Looking at the grammar for PostgreSQL's select statement, it defines one form of from_item as:

    from_item [ NATURAL ] join_type from_item [ ON join_condition | USING ( join_column [, ...] ) ]

So this looks like it should be an option on the join itself (an alternative to "ON") rather than a separate type of join expression. Am I missing something?

[Thomas Herve (therve)]

I'm not sure what's your point. USING is mainly useful for DELETE statements.

[James Henstridge (jamesh)]

The code in Jamu's branch appeared to be generating USING clauses in SELECT statements. I agree that supporting "DELETE ... FROM ... USING ..." would be useful, but I think that would be better to do as part of the Delete() expression object and compile functions (so we can provide "auto tables" behaviour).

[Thomas Herve (therve)]

Ah ok. I think Jamu started this branch after a discussion with me, so I'm not sure he got what I meant at this time :). I agree that your approach looks saner.

[Jamu Kakar (jkakar)]

I'm unassigning this for the time being, as I'm not working on it.