HookManager emits warnings when hooks aren't loaded

Bug #1611387 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
stevedore
Fix Released
Medium
Doug Hellmann

Bug Description

Ever since this change:

https://review.openstack.org/#/c/334014/

We get a lot of warnings in the nova logs for hooks that aren't loaded, e.g.:

http://logs.openstack.org/66/329466/4/check/gate-tempest-dsvm-multinode-live-migration/586c6be/logs/subnode-2/screen-n-cpu.txt.gz#_2016-08-03_00_45_26_933

2016-08-03 00:45:26.933 21672 WARNING stevedore.named [req-97af3388-11a8-4d5f-8e7e-9ae81a77b2ee tempest-LiveAutoBlockMigrationV225TestJSON-1828802368 tempest-LiveAutoBlockMigrationV225TestJSON-1828802368] Could not load instance_network_info

That comes from this hook:

https://github.com/openstack/nova/blob/master/nova/network/base_api.py#L33

Nova has it's own extension of the stevedore HookManager:

https://github.com/openstack/nova/blob/master/nova/hooks.py#L69

But Nova doesn't define hooks in tree. It seems that the HookManager in stevedore should provide a no-op callback to on_missing_entrypoints_callback in the NamedExtensionManager to avoid these warnings.

no longer affects: python-stevedore
affects: stevedore → python-stevedore
Changed in python-stevedore:
assignee: nobody → Doug Hellmann (doug-hellmann)
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stevedore (master)

Fix proposed to branch: master
Review: https://review.openstack.org/353029

Changed in python-stevedore:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stevedore (master)

Reviewed: https://review.openstack.org/353029
Committed: https://git.openstack.org/cgit/openstack/stevedore/commit/?id=62398ed4a3376b52e0934a9e23b88bea60404972
Submitter: Jenkins
Branch: master

commit 62398ed4a3376b52e0934a9e23b88bea60404972
Author: Doug Hellmann <email address hidden>
Date: Tue Aug 9 13:30:08 2016 -0400

    do not emit warnings for missing hooks

    Add a flag to disable the default warning log messages in the
    NamedExtensionManager and then have the HookManager pass False by
    default.

    Change-Id: I78c91bcfd8cd41929f25057791157f82eb4a3a50
    Closes-Bug: #1611387
    Signed-off-by: Doug Hellmann <email address hidden>

Changed in python-stevedore:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/stevedore 1.17.1

This issue was fixed in the openstack/stevedore 1.17.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/stevedore 1.17.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.