code cosmetic fixes

Bug #1576396 reported by Tony Tan on 2016-04-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
steth
Medium
Unassigned

Bug Description

Currently the repo uses python 2.x style print statement, this poses a hurdle for supporting Python 3.x down the line. Most OpenStack projects require python3.4 support.

Also some requirements.txt dependencies need to be updated (namely, scapy (needs scapy-python3 to run in Python 3), and an unused function generate-uuid has bee removed as well,

Changed in steth:
status: New → Confirmed
importance: Undecided → Medium
Tony Tan (tonytan4ever) on 2016-05-02
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to steth (master)

Reviewed: https://review.openstack.org/311922
Committed: https://git.openstack.org/cgit/openstack/steth/commit/?id=352c65725d5d223f255fbb692693ceacca21520b
Submitter: Jenkins
Branch: master

commit 352c65725d5d223f255fbb692693ceacca21520b
Author: Tin Lam <email address hidden>
Date: Mon May 2 21:26:17 2016 -0500

    Apply general code clean-up and fixes

    * Removed unused generate_uuid method.
    * Changed print statement from 2.x style to 3.x.
    * Updated scrapy to scrapy-python3 in requirements.txt for py3
      compatibility.

    Change-Id: I7255a57c85cde105bf83bf6de5e779b71a09f8ee
    Closes-Bug: #1576396

Changed in steth:
status: Confirmed → Fix Released
Revision history for this message
Gerard Braad (gbraad) wrote :

Please search issues and pull requests before adding something new to avoid duplicating efforts and conversations. Especially, when working on a bug you should assign it to yourself before starting to work on it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on steth (master)

Change abandoned by tonytan4ever (<email address hidden>) on branch: master
Review: https://review.openstack.org/310895
Reason: Similar fix has been in place

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers