setObserverLocation re-enables landscape, when setFlagLandscape false

[Phil Shepherd]

Stellarium version 0.18.1 :

I have a short script showing a quick trip to the Moon.

- Initial landscape set on
- set alt / az view
- pause
- setFlagLandscape(false)
- setObserverLocation using a duration animation of 10 seconds to show travel to the Moon

The landscape appears as soon as motion starts.

example script attached

Phil

[Phil Shepherd (psjshep)]

btw, I have tried all sorts of combinations... each time, the landscape appears as soon as setObserverLocation is called...

fyi

[Alexander Wolf (alexwolf)]

Fixed auto-enabling landscapes when setObserverLocation is call: https://github.com/Stellarium/stellarium/commit/c689edd4d6798dd828547fdb3526cdadc2bd25d3

I've renamed option "Auto-enabling for the atmoshere" to the "Auto-enabling for the environment" and enhance the behavior of this feature to the landscapes too. By default this option is enabled in the GUI and end-user will be see no changes in behavior.

In scripts this feature can be disabled throug calling special method:
LandscapeMgr.setFlagEnvironmentAntoEnabe(false);

Work-around for previous versions of Stellarium (0.18.0-0.18.1 and maybe 0.17.x) is simple: call LandscapeMgr.setFlagLandscape() after calling core.setObserverLocation();

Methods LandscapeMgr::setFlagAtmosphereAutoEnable() and LandscapeMgr::getFlagAtmosphereAutoEnable() marked as deprecated and keep in the code for backward compatibility. Both deprecated methods will be removed in next series.

[Phil Shepherd (psjshep)]

Nice 1, Alexander... thanks

Just a quick question about the feature enhancement:

Will the ability to seperately set/unset the atmostphere and landscape still be available?

I sometimes show the effect of atmosphere & light polution by switching off the atmosphere - highly effective.

Phil

[Phil Shepherd (psjshep)]

o, & when will these changes be in the next Beta?

Phil

[Alexander Wolf (alexwolf)]

> Will the ability to seperately set/unset the atmostphere and landscape still be available?

Yes, of course.

New method LandscapeMgr::setFlagEnvironmentAutoEnabe(); just enables or disables the automatic enabling of atmosphere, fog and landscape when location is changed.

[Phil Shepherd (psjshep)]

thx

[Phil Shepherd (psjshep)]

When will these changes make their way into a Windows build? I am not able to compile for that.

Thanks,
Phil

[gzotti (georg-zotti)]

Alexander tirelessly makes betas for all platforms almost every weekend.

[Phil Shepherd (psjshep)]

... and very much appreciated it is

Thanks

Phil

[Phil Shepherd (psjshep)]

I have successfully tested my scripting with the new functionality - works as described...

Thank you...

When is it likely to appear in the next production release?

Phil

[Alexander Wolf (alexwolf)]

The next release will be in few next days, maybe week.