Create stellarium.rc in build tree instead of source tree

Bug #1571391 reported by Florian Schaukowitsch on 2016-04-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stellarium
Low
Unassigned

Bug Description

A very minor thing that has been bugging me for a while:

On Windows, the "stellarium.rc" resource file which contains the app icon/version info is currently generated in "${CMAKE_SOURCE_DIR}/data". Because it is an auto-generated file (from stellarium.rc.cmake), it should probably be created in the build tree (${CMAKE_BINARY_DIR}) to keep the source clean. This also prevents the file needing to be ignored in bzr (which it is NOT currently).

The attached patch does this, plus it also moves the stellarium.rc.cmake template to the "src" dir instead of the "data" dir (because for Windows it IS essentially a source file, and no data file). The icon path in the .rc file is simply set to the absolute path using a cmake macro.

Tested using MSVC13 and MinGW.

By the way:
Similar things can probably be said about the .iss files (InnoSetup scripts), but changing this would probably need a buildbot change?

gzotti (georg-zotti) wrote :

Oh, good find! Is this a reason why an open bzr crashes on every build?

Florian Schaukowitsch (fschauk) wrote :

Do you mean your BZR Explorer crashes each time you build? I don't have/know about this problem, so I don't know if it would help.

gzotti (georg-zotti) wrote :

Yes, BZR signals a crash panel (with ignore/continue option) at end of build. I build in a "build" subdir of trunk. Maybe building in another dir would help, have not tried this yet.

Changed in stellarium:
milestone: none → 0.15.0
importance: Undecided → Low
status: New → Fix Committed
Changed in stellarium:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers