Stellarium fails to build with Qt 5.5 - missing includes

Bug #1504595 reported by Kristyna Streitova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stellarium
Fix Released
Undecided
Unassigned

Bug Description

Stellarium 0.13.3 fails to build with Qt 5.5 due to missing includes. The issue is likely that stellarium relied on implicit header includes from earlier versions of libQt (< 5.5).

The important parts of the build log are:

[ 271s] In file included from /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/core/StelSkyCultureMgr.cpp:20:0:
[ 271s] /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/core/StelSkyCultureMgr.hpp:47:1: error: expected class-name before '{' token
[ 271s] {
[ 271s] ^
[ 271s] /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/core/StelSkyCultureMgr.hpp:48:2: error: 'Q_OBJECT' does not name a type
[ 271s] Q_OBJECT
[ 271s] ^
[ 271s] /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/core/StelSkyCultureMgr.hpp:62:8: error: expected ':' before 'slots'
[ 271s] public slots:

and

[ 47s] In file included from /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/CLIProcessor.cpp:20:0:
[ 47s] /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/CLIProcessor.hpp:64:9: error: 'QVariant' does not name a type
[ 47s] static QVariant argsGetOptionWithArg(const QStringList& argList, QString shortOpt, QString longOpt, QVariant defaultValue);
[ 47s] ^
[ 47s] /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/CLIProcessor.cpp: In static member function 'static void CLIProcessor::parseCLIArgsPreConfig(const QStringList&)':
[ 47s] /home/abuild/rpmbuild/BUILD/stellarium-0.13.3/src/CLIProcessor.cpp:104:68: error: 'argsGetOptionWithArg' was not declared in this scope
[ 47s] newUserDir = argsGetOptionWithArg(argList, "-u", "--user-dir", "").toString();
[ 47s] ^

Attaching proposed patch.

Revision history for this message
Kristyna Streitova (kstreitova) wrote :
Revision history for this message
Alexander Wolf (alexwolf) wrote :

Thanks for patch, but this issue already fixed in branch for series 0.13 - http://bazaar.launchpad.net/~stellarium/stellarium/0.13/revision/6940

Changed in stellarium:
status: New → Fix Committed
Revision history for this message
Alexander Wolf (alexwolf) wrote :

It fixed in series 0.14 too

gzotti (georg-zotti)
Changed in stellarium:
milestone: none → 0.14.0
Revision history for this message
Kristyna Streitova (kstreitova) wrote :

Sorry, I didn't notice. Thank you for information.

Changed in stellarium:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.