Scenery3d: some fields are not being stored

Bug #1502245 reported by Marcos Cardinot on 2015-10-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stellarium
Low
gzotti

Bug Description

Scenery3D plugin!

It seems that fields like:
- "set as default scene"
- "torchlight"
- "show grid coordinates"
are not being stored on the config.ini file.

Related branches

Changed in stellarium:
assignee: nobody → gzotti (georg-zotti)
milestone: none → 0.14.0
importance: Undecided → Low
gzotti (georg-zotti) wrote :

default location is stored.
torchlight and display of coordinates are so ephemeral settinga that I did not want to store them.
Do you really think we need it?

Changed in stellarium:
status: New → Opinion
Marcos Cardinot (cardinot) wrote :

> default location is stored.

are you sure?

test cases:
1)
- open the settings dialog (3d scenery)
- set "testscene" as default
- select the "sterngarten" scene
- select the "testscene" again
-> checkbox is blank

2)
- open the settings dialog
- set "testscene" as default
- close stellarium
- open stellarium and the settings dialog (3d scenery)
-> checkbox is blank

I was checking the code, and I saw that we get the value of "default_location_id" in Scenery3dMgr::loadConfig().
However, it seems that we never set a value for this key...

> torchlight and display of coordinates are so ephemeral settinga that I did not want to store them.
> Do you really think we need it?

I got your point, but I think that we should make Stellarium remember these options too... For example, if I'm an user who wants to always see the grid coordinates, why should I need to check this box all the time?

gzotti (georg-zotti) wrote :

OK, the checkbox may not be re-filled if we load the default scene. However a value is placed into config.ini.
The other two, light and coords, are switchable via hotkeys. But OK, it may be meaningful for the coordinate display to have it as permanent option for researchers.

In general, there is some inconsistence around settings. Some are remembered when you set them, others only when you click "store defaults". I think we should get rid of "store defaults" (except for view direction/fov) and set values in config immediately.

Changed in stellarium:
milestone: 0.14.0 → 0.16.0
gzotti (georg-zotti) wrote :

1) I can only assume Florian has fixed the default scene display handling.

2&3) r9542 stores light and coordinate display usage to config.

Changed in stellarium:
status: Opinion → In Progress
status: In Progress → Fix Committed
Changed in stellarium:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers