Segmentation fault on failed shader compilation/linking
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Stellarium |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Hi,
this report is an offshot of https:/
if (!vshader.
It would be great if Stellarium could try to compile its shaders at the beginning and show a nice window saying that it cannot run. It would be even greater if in this case some fallback shaders could be tried so that Stellarium can run on older hardware that cannot compile/link the standard ones.
Cheers,
Tomasz
Related branches
- Fabien Chéreau: Disapprove
- Tomasz Buchert: Pending requested
-
Diff: 472 lines (+192/-76)5 files modifiedsrc/CLIProcessor.cpp (+3/-0)
src/core/StelPainter.cpp (+102/-46)
src/core/StelPainter.hpp (+8/-1)
src/core/modules/Planet.cpp (+75/-24)
src/main.cpp (+4/-5)
- gzotti: Approve
- Alexander Wolf: Approve
- Fabien Chéreau: Pending requested
-
Diff: 741 lines (+412/-114)8 files modifiedplugins/AngleMeasure/src/AngleMeasure.cpp (+14/-1)
plugins/CompassMarks/src/CompassMarks.cpp (+10/-0)
src/StelMainView.cpp (+332/-58)
src/StelMainView.hpp (+15/-2)
src/core/StelOpenGL.hpp (+6/-0)
src/core/modules/GridLinesMgr.cpp (+12/-2)
src/core/modules/Planet.cpp (+4/-0)
src/main.cpp (+19/-51)
description: | updated |
Changed in stellarium: | |
importance: | Undecided → High |
tags: | added: opengl |
Changed in stellarium: | |
milestone: | none → 0.13.2 |
Changed in stellarium: | |
assignee: | nobody → gzotti (georg-zotti) |
status: | New → In Progress |
Changed in stellarium: | |
assignee: | gzotti (georg-zotti) → nobody |
Changed in stellarium: | |
milestone: | 0.13.2 → none |
Changed in stellarium: | |
milestone: | none → 0.15.0 |
Changed in stellarium: | |
status: | In Progress → Fix Released |
The problem is known since May/June or so.
All I can see is that OP has some outdated GeForce 7300 GPU from around 2006 with GLSL1.2, which is simpy not supported by 0.13+. We demand more modern hardware.
There are no fallback shaders, although yes it would be nice to have some minimal GLSL1.2 shaders with less functionality. On the other hand, a new minimal-level desktop graphics card that works nowadays costs €50 or less. Alternatively, Alexander is working on backports to keep 0.12.x alive for such outdated hardware.
Some shader compilers emit zero output if all is fine, others (Intel? ) say "no errors" or similar. If all "false positive" warnings can be excluded, a "fail" panel and graceful exit could be added. However, a simple look into the logfile and reading the FAQ is all you need to resolve this.