Tooltips are not affected by night mode

Bug #1300801 reported by henrysky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stellarium
Fix Released
Low
Guillaume Chereau

Bug Description

All explanatory text is not red colored in night mode
The image below is an example

Revision history for this message
henrysky (henry-leung-2010) wrote :
Changed in stellarium:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Guillaume Chereau (guillaume-chereau)
summary: - Explanatory text is not red colored in night mode
+ Tooltips are not affected by night mode
Revision history for this message
Alexander Wolf (alexwolf) wrote :

Argh... Style sheet is not defined for QToolTips and apparently style is not applied correctly.

Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

Maybe using QToolTip::setPalette ?

Revision history for this message
Alexander Wolf (alexwolf) wrote :

>Maybe using QToolTip::setPalette ?

Maybe, but better will be repair the application of styles for whole application (or fix night mode rules for tooltip's)

Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote : Re: [Bug 1300801] Re: Tooltips are not affected by night mode

On Mon, Aug 17, 2015 at 05:34:15PM -0000, Alexander Wolf wrote:
> >Maybe using QToolTip::setPalette ?
>
> Maybe, but better will be repair the application of styles for whole
> application (or fix night mode rules for tooltip's)

The thing is that now the night mode is implemented using a shader
effect, so the night mode style is actually not used. I guess we could
remove it totally. The tooltips are not affected by the shader because
Qt show them outside of the window.

I will check if there is a simple way to fix this.

Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

OK, I just pushed a simple fix for this: r7836.

Revision history for this message
Alexander Wolf (alexwolf) wrote :

I agree - we can remove old stylesheet for night mode.

Important note: your patch fixed tooltip behaviour in night mode partially - he doesn't work for toolbars (e.g. bottom bar) and plugins (e.g. Oculars).

Changed in stellarium:
milestone: none → 0.14.0
status: Confirmed → In Progress
Revision history for this message
Guillaume Chereau (guillaume-chereau) wrote :

That's right... Let me have a look.

Changed in stellarium:
status: In Progress → Fix Committed
Changed in stellarium:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.