Broken key sequence for shortcuts

[Alexander Wolf]

This bug report related to question #245630.

After introducing new manager for shortcuts some bindings is broken now. For example - key sequence for shortcuts like "Alt+P, 1" didn't work now.

[Guillaume Chereau (guillaume-chereau)]

Normally all the old shortucts from 'default_shortcuts.json' should have been put directly in the cpp code, but maybe I forgot some of them.

What was the "Alt+P, 1" shortcut assigned to? I cannot find it in 'default_shortcuts.json'. Are there any other shortcuts you found missing?

[Alexander Wolf (alexwolf)]

It's not exactly missing. As example the code contains shortcut for stop script execution - Ctrl+D, S - but this shortcut doesn't work. Next samples: Ctrl+D, P (Pause script execution), Ctrl+D, R (Resume script execution), Ctrl+U, 1 (Show and zoom Moon - we lost embedded scripts for shortcuts too), and Ctrl+U, 2 (Run landscapes script from file).

[Guillaume Chereau (guillaume-chereau)]

On Wed, Mar 19, 2014 at 03:22:12AM -0000, Alexander Wolf wrote:
> It's not exactly missing. As example the code contains shortcut for stop
> script execution - Ctrl+D, S - but this shortcut doesn't work. Next
> samples: Ctrl+D, P (Pause script execution), Ctrl+D, R (Resume script
> execution)
OK, there might be a bug somewhere. I just tried and it seems to work
on my machine though (running GNU/linux).

> Ctrl+U, 1 (Show and zoom Moon)
Yes, we lost this one since it was an embedded script.

> - we lost embedded scripts for
> shortcuts too), and Ctrl+U, 2 (Run landscapes script from file).
For the embedded scripts, I think it makes more sense to add them as
normal scripts, and them assign a shortcut to it. Is there a need to
mix scripts with the configuration files?

It would be trivial to add the show moon script back, and assign it
Ctrl+U, 1 the shortcut if this is needed.

[Guillaume Chereau (guillaume-chereau)]

On my computer, Ctrl+D, [S, P, R] all seem to work. Maybe there is a problem with the Russian keyboard layout? Can you try with an English layout?

For the embedded scripts, I don't really feel that they are important. I think It makes more sense to add a normal script and then assign a shortcut to it. Is there a need for that?

[Alexander Wolf (alexwolf)]

On my system Ctrl+D, [S, P, R] doesn't work on both - English and Russian - layouts. :(

I think embedded scripts don't needed, but it's should discuss.

Plus please try set new key sequence for any scripts as example.

[Guillaume Chereau (guillaume-chereau)]

OK, I just added a shortcut for the constellation tour script (ctrl-U,1) in the default config file. commit 6687.

[Alexander Wolf (alexwolf)]

After revision 6709 all my custom shortcuts (like Ctrl+U,1 for scripts) works now. But I have problem for Ctrl+D, [S, P, R] still - troubles in scripting engine?

[Guillaume Chereau (guillaume-chereau)]

On Tue, Apr 08, 2014 at 04:45:50PM -0000, Alexander Wolf wrote:
> After revision 6709 all my custom shortcuts (like Ctrl+U,1 for scripts)
> works now. But I have problem for Ctrl+D, [S, P, R] still - troubles in
> scripting engine?
Yeah I suspect this might be a problem of the scripting engine. Are
testing a script in particular?

I attach a small patch that adds debug output to the Ctrl+D, [S, P, R]
actions. Can you try it out and check that you actually see the output
when you press the keys?

[Alexander Wolf (alexwolf)]

Yeah, this is bug in scripting engine.

I get those lines:
TEST stopScript
"script error: "JavaScript execution exceeded timeout." @ line 0"
TEST pauseScript
TEST stopScript

[Guillaume Chereau (guillaume-chereau)]

Can you tell me with what script in particular the bug can be
reproduced?

[Alexander Wolf (alexwolf)]

You can use solar eclipse.ssc for it (and other eclipse scripts)

[Alexander Wolf (alexwolf)]

Guillaume, any progress?

[Alexander Wolf (alexwolf)]

Hm. I checked it and it works now.

[Guillaume Chereau (guillaume-chereau)]

OK good, it also still works for me.