Currently, the HTTP response code from software deploy host is used to
determine if the command was successfully. However, a recent change has
caused failed deploy hosts to return 200 tricking VIM into thinking they
worked.
This change forces VIM to always check the deploy host status instead of
using the HTTP code.
TEST PLAN:
PASS: AIO-SX minor upgrade
* No impact when deploy host succeeds
PASS: AIO-SX major upgrade
* No impact when deploy host succeeds
PASS: Standard minor upgrade
* deploy-host-failed detected correctly
Reviewed: https:/ /review. opendev. org/c/starlingx /nfv/+/ 938965 /opendev. org/starlingx/ nfv/commit/ a8d6da428ee78da ed264a875247344 2031eaadaf
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit a8d6da428ee78da ed264a875247344 2031eaadaf
Author: Joshua Kraitberg <email address hidden>
Date: Fri Jan 10 16:54:49 2025 -0500
Always verify status of software deploy host
Currently, the HTTP response code from software deploy host is used to
determine if the command was successfully. However, a recent change has
caused failed deploy hosts to return 200 tricking VIM into thinking they
worked.
This change forces VIM to always check the deploy host status instead of
using the HTTP code.
TEST PLAN:
PASS: AIO-SX minor upgrade
* No impact when deploy host succeeds
PASS: AIO-SX major upgrade
* No impact when deploy host succeeds
PASS: Standard minor upgrade
* deploy-host-failed detected correctly
Closes-Bug: 2093792 907e8340382f05a 482dfb9bc38
Change-Id: I9c8150b56296f2
Signed-off-by: Joshua Kraitberg <email address hidden>