Restore of duplex subcloud for inactive/previous release load failed with unable to install patches

[Joshua Kraitberg]

Brief Description
------
Restore of duplex subcloud is failed as unable to install patches

Severity
-----
Major

Steps to Reproduce
-----
1) Deploy the duplex subcloud (subcloud3) with inactive load

2) Perform the backup operation for the central storage

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud list
{}{}{}{}{}--{}{}{}{}{}{}{}{}{}--{}{}{}{}{}{}{}{}----{}{}{}{}{}{}{}{}{}-----{}{}{}{}{}{}{}{}---{}{}{}{}{}{}{}{}{}--------{}{}{}{}{}{}{}{}------------{+}

id name       management availability deploy status sync         backup status     prestage status

{}{}{}{}{}--{}{}{}{}{}{}{}{}{}--{}{}{}{}{}{}{}{}----{}{}{}{}{}{}{}{}{}-----{}{}{}{}{}{}{}{}---{}{}{}{}{}{}{}{}{}--------{}{}{}{}{}{}{}{}------------{+}

 2 subcloud1 managed     online       complete       out-of-sync complete-central None
 4 subcloud3 managed     online       complete       out-of-sync complete-central None

{}{}{}{}{}--{}{}{}{}{}{}{}{}{}--{}{}{}{}{}{}{}{}----{}{}{}{}{}{}{}{}{}-----{}{}{}{}{}{}{}{}---{}{}{}{}{}{}{}{}{}--------{}{}{}{}{}{}{}{}------------{+}

3) Restore the subcloud3

dcmanager subcloud-backup restore --subcloud subcloud3 --with-install --sysadmin-password Li69nux*1234 --release 22.12

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud list
{}{}{}{}{}--{}{}{}{}{}{}{}{}{}--{}{}{}{}{}{}{}{}----{}{}{}{}{}{}{}{}{}------{}{}{}{}{}{}{}{}---{}{}{}{}{}{}{}{}{}--------{}{}{}{}{}{}{}{}------------{+}

id name       management availability deploy status   sync         backup status     prestage status

{}{}{}{}{}--{}{}{}{}{}{}{}{}{}--{}{}{}{}{}{}{}{}----{}{}{}{}{}{}{}{}{}------{}{}{}{}{}{}{}{}---{}{}{}{}{}{}{}{}{}--------{}{}{}{}{}{}{}{}------------{+}

 2 subcloud1 unmanaged   online       complete       out-of-sync complete-central None
 4 subcloud3 unmanaged   offline       restore-failed unknown     complete-central None

{}{}{}{}{}--{}{}{}{}{}{}{}{}{}--{}{}{}{}{}{}{}{}----{}{}{}{}{}{}{}{}{}------{}{}{}{}{}{}{}{}---{}{}{}{}{}{}{}{}{}--------{}{}{}{}{}{}{}{}------------{+}
[sysadmin@controller-0 ~(keystone_admin)]$

Expected Behavior
-----
Restore should be successful

Actual Behavior
-----
Restore is failing

Reproducibility
-----
Yes

System Configuration
-----
DC + multi-node subclouds
-----
Load info (eg: 2022-03-10_20-00-07)

2024-05-07 16:04:25 +0000

Last Pass
-----

Timestamp/Logs
-----
TASK [restore-platform/restore-sw-patches : Apply patches] *********************
    Wednesday 15 May 2024  09:53:38 +0000 (0:00:00.628)       0:00:14.549 *********
    fatal: [localhost]: FAILED! => changed=true
      cmd:
      - sw-patch
      - install-local
      delta: '0:00:01.660197'
      end: '2024-05-15 09:53:40.870852'
      msg: non-zero return code
      rc: 1
      start: '2024-05-15 09:53:39.210655'
      stderr: 'Error: Failed to install patches. Please check /var/log/patching.log for details'
      stderr_lines: <omitted>
      stdout: ''
      stdout_lines: <omitted>

Alarms
-----

Test Activity
-----
Feature Testing

Workaround
-----
To have patching be skipped during restore:
Include skip_patches_restore=true as a restore value

# path/to/values.yaml
---
skip_patches_restore: true
dcmanager subcloud-backup restore --restore-values path/to/values.yaml ...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/922334
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/42387529809685c6ac9e42fc25039761662abd55
Submitter: "Zuul (22348)"
Branch: master

commit 42387529809685c6ac9e42fc25039761662abd55
Author: Joshua Kraitberg <email address hidden>
Date: Wed Jun 19 11:38:08 2024 -0400

    Skip restore patching for subclouds

    Subclouds already have patches committed and don't need them
    reapplied during legacy restore.

    TEST PLAN
    PASS: Subcloud restore AIO-SX
    PASS: Subcloud restore AIO-DX previous release
    PASS: Subcloud restore AIO-DX current release

    Closes-Bug: 2069838
    Change-Id: I18fdfec2d3f8023a3b34265695b1f0e854952e0f
    Signed-off-by: Joshua Kraitberg <email address hidden>