software deploy start reentrant causing message error

Bug #2069469 reported by Bin Qian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Bin Qian

Bug Description

rerun software deploy start after software deploy in start state, receive error

software deploy start starlingx-25.03.0
Error:
Internal error occurred. Error signature [b581e479]

From software.log:
2024-06-14T18:53:38: software-controller-daemon[5072:140502922807040]: utils.py(62): ERROR: 'NoneType' object has no attribute 'value'
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pecan/core.py", line 683, in __call__
    self.invoke_controller(controller, args, kwargs, state)
  File "/usr/lib/python3/dist-packages/pecan/core.py", line 574, in invoke_controller
    result = controller(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/software/api/controllers/v1/deploy.py", line 70, in start
    result = sc.software_deploy_start_api(release, _force)
  File "/usr/lib/python3/dist-packages/software/deploy_state.py", line 187, in exec_op
    require_states_text = ", ".join([state.value for state in require_states])
  File "/usr/lib/python3/dist-packages/software/deploy_state.py", line 187, in <listcomp>
    require_states_text = ", ".join([state.value for state in require_states])
AttributeError: 'NoneType' object has no attribute 'value'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to update (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/922051

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to update (master)

Reviewed: https://review.opendev.org/c/starlingx/update/+/922051
Committed: https://opendev.org/starlingx/update/commit/2d37204b19e5d5503f05f40c7aed3b990c1e7853
Submitter: "Zuul (22348)"
Branch: master

commit 2d37204b19e5d5503f05f40c7aed3b990c1e7853
Author: Bin Qian <email address hidden>
Date: Fri Jun 14 18:55:59 2024 +0000

    Fix error on rerun software deploy start

    This is to fix an error rerun software deploy start
    right after running the same command.
    The change fixes the error message formatting error during
    the operation.

    Closes-bug: 2069469
    TCs:
         passed: rerun the command as described, see the correct
                 operation error message.

    Change-Id: I0df3c200f8ccaab733175da415877621832bd9a5
    Signed-off-by: Bin Qian <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
tags: added: stx.10.0 stx.update
Changed in starlingx:
assignee: nobody → Bin Qian (bqian20)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.