Subprocess failing to call apt-ostree compose install

[Lindley Werner Soares Vieira]

Brief Description
-----------------
During "software deploy start" when calling apt-ostree compose install, the subprocess return with the error:

subprocess.CalledProcessError: Command '['apt-ostree', 'compose', 'install', '--repo', '/var/www/pages/feed/rel-24.03/ostree_repo', '--branch', 'starlingx', '--feed', '"http://controller:8080/updates/debian/rel-24.03/ bullseye updates"', 'curl starlingx-dashboard']' returned non-zero exit status 1.

Severity
--------
Critical: System/Feature is not usable due to the defect

Steps to Reproduce
------------------
Run "software deploy start" in a patch apply process

Expected Behavior
------------------
The command run with success

Actual Behavior
----------------
Returning error

Reproducibility
---------------
Reproducible, reported by 2 different people

System Configuration
--------------------
USM

Branch/Pull Time/Commit
-----------------------
Branch and the time when code was pulled or git commit or cengn load info

Last Pass
---------
Did this test scenario pass previously? If so, please indicate the load/pull time info of the last pass.
Use this section to also indicate if this is a new test scenario.

Timestamp/Logs
--------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/software/apt_utils.py", line 81, in run_install
    subprocess.run(
  File "/usr/lib/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['apt-ostree', 'compose', 'install', '--repo', '/var/www/pages/feed/rel-24.03/ostree_repo', '--branch', 'starlingx', '--feed', '"http://controller:8080/updates/debian/rel-24.03/ bullseye updates"', 'curl starlingx-dashboard']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/software/software_controller.py", line 2457, in software_deploy_start_api
    apt_utils.run_install(feed_repo, packages)
  File "/usr/lib/python3/dist-packages/software/apt_utils.py", line 94, in run_install
    raise APTOSTreeCommandFail(msg)
software.exceptions.APTOSTreeCommandFail: Failed to install packages.
2024-05-24T11:31:12: software-controller-daemon[3008:140431789442816]: utils.py(62): ERROR: Starting deployment for: starlingx-24.03.1
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/software/apt_utils.py", line 81, in run_install
    subprocess.run(
  File "/usr/lib/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['apt-ostree', 'compose', 'install', '--repo', '/var/www/pages/feed/rel-24.03/ostree_repo', '--branch', 'starlingx', '--feed', '"http://controller:8080/updates/debian/rel-24.03/ bullseye updates"', 'curl starlingx-dashboard']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/software/software_controller.py", line 2457, in software_deploy_start_api
    apt_utils.run_install(feed_repo, packages)
  File "/usr/lib/python3/dist-packages/software/apt_utils.py", line 94, in run_install
    raise APTOSTreeCommandFail(msg)
software.exceptions.APTOSTreeCommandFail: Failed to install packages.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pecan/core.py", line 683, in __call__
    self.invoke_controller(controller, args, kwargs, state)
  File "/usr/lib/python3/dist-packages/pecan/core.py", line 574, in invoke_controller
    result = controller(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/software/api/controllers/v1/deploy.py", line 62, in start
    result = sc.software_deploy_start_api(release, _force)
  File "/usr/lib/python3/dist-packages/software/deploy_state.py", line 190, in exec_op
    res = func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/software/software_controller.py", line 2460, in software_deploy_start_api
    raise APTOSTreeCommandFail(msg)
software.exceptions.APTOSTreeCommandFail: Starting deployment for: starlingx-24.03.1

Test Activity
-------------
[Sanity, Feature Testing, Regression Testing, Developer Testing, Evaluation, Other - Please specify]

Workaround
----------
Add shell=True in the subprocess command call

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/920402

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/921015

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Lindley Werner Soares Vieira <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/update/+/920402
Reason: Not the solution

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Lindley Werner Soares Vieira <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/update/+/921015
Reason: Already fixed https://review.opendev.org/c/starlingx/update/+/920668