nfs-mount returns error code 32

[Heitor Matsui]

Brief Description
-----------------
nfs-mount used by software_functions module fails with error rc=32 during software deploy host for major release

Severity
--------
Major

Steps to Reproduce
------------------
- upload iso/sig
- software deploy start
- software deploy host

Expected Behavior
------------------
Agent hooks are executed successfully during deploy host

Actual Behavior
----------------

Agent hook that uses nfs-mount fails

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
N/A

Timestamp/Logs
--------------
2024-05-18T06:06:51: software-agent[960038:139972736378688]: agent_hooks.py(113): INFO: Not running in active controller, mounting controller-platform-nfs:/opt/platform into /var/run/platform
2024-05-18T06:06:51: software-agent[960038:139972736378688]: software_functions.py(1419): ERROR: Error mounting remote controller-platform-nfs:/opt/platform into local /var/run/platform: Command '['/bin/nfs-mount', 'controller-platform-nfs:/opt/platform', '/var/run/platfo
rm']' returned non-zero exit status 32.
2024-05-18T06:06:51: software-agent[960038:139972736378688]: agent_hooks.py(124): ERROR: Error running reconfigure kernel hook: Command '['/bin/nfs-mount', 'controller-platform-nfs:/opt/platform', '/var/run/platform']' returned non-zero exit status 32.
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/software/agent_hooks.py", line 115, in run
    with mount_remote_directory(remote_dir, local_dir):
  File "/usr/lib/python3.9/contextlib.py", line 117, in __enter__
    return next(self.gen)
  File "/usr/lib/python3/dist-packages/software/software_functions.py", line 1417, in mount_remote_directory
    os.mkdir(local_dir, 0o755)
  File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/bin/nfs-mount', 'controller-platform-nfs:/opt/platform', '/var/run/platform']' returned non-zero exit status 32.

Test Activity
-------------
Feature Testing

Workaround
----------
Create /var/run/platform on the target host before running deploy host

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/920317

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/update/+/920317
Committed: https://opendev.org/starlingx/update/commit/14516bd45caf189ee279575630fb95def0af747d
Submitter: "Zuul (22348)"
Branch: master

commit 14516bd45caf189ee279575630fb95def0af747d
Author: Heitor Matsui <email address hidden>
Date: Thu May 23 15:49:33 2024 -0300

    Check and create nfs mount directory

    This commit checks if a mountpoint directory exists, and if not
    then creates the directory before attempting to mount.

    Test Plan
    PASS: run the function manually and verify it mounts successfully
    PASS: run deploy host for major release and verify agent hooks
          (which use the changed function) run successfully

    Closes-bug: 2066973

    Change-Id: I987721b2a59d534acdc1f3c2ca5f2046227d1274
    Signed-off-by: Heitor Matsui <email address hidden>