Unable to remove NIC from bond in Horizon GUI for controller-0

[Mohammad Issa]

Brief Description
-----------------
Unable to remove NIC from bond in Horizon GUI for controller-0. It works for controller-1 and worker-0 though.

Severity
--------
Minor

Steps to Reproduce
------------------
Bring up a duplex where controller-0 mgmt is in an ae bond. lock controller-0 and try to remove one of the lower interfaces on Horizon.

Expected Behavior
------------------
lower interface successfully removed.

Actual Behavior
----------------
Key error.

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Duplex

Last Pass
---------

Timestamp/Logs
--------------

Test Activity
-------------
Developer Testing

Workaround
----------

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/gui/+/920148
Committed: https://opendev.org/starlingx/gui/commit/b4eb3adb00e0be8b80cfd39d63e2a089f998e323
Submitter: "Zuul (22348)"
Branch: master

commit b4eb3adb00e0be8b80cfd39d63e2a089f998e323
Author: Mohammad Issa <email address hidden>
Date: Tue May 21 19:19:39 2024 +0000

    Unable to remove NIC from bond in Horizon

    Unable to remove a lower interface from a mgmt type interface
    on controller-0 using Horizon.

    The values in the 'uses' field received from Horizon
    requests are the UUIDs of the lower interfaces. The sysinv
    code expects ifname.

    The conversion was already handled in adding
    an interface, but not when updating an interface.

    Testing:
    - Build successful
    - Test removing any lower interface and adding it back
    - Test removing lower interface related to the original mgmt mac
      -> verify that it does reselect the original mgmt mac

    Closes-Bug: 2066400

    Change-Id: Ifd51814f90cabee88c5457128ad6ddbdac2e975c
    Signed-off-by: Mohammad Issa <email address hidden>