Proposed action for 'dcmanager subcloud error' for bootstrap failure needs to be updated

[Raphael Lima]

Brief Description
-----------------

It is possible to perform a subcloud bootstrap without deleting and re-adding the subcloud, but the proposed action for bootstrap failures currently shows:

"For bootstrap failures, please delete and re-add the subcloud after the cause of failure has been resolved"

When a better proposed action message would be:

"For bootstrap failures, please use 'dcmanager subcloud deploy bootstrap' after the cause of failure has been resolved"

Severity
-----------------

Minor: System/Feature is usable with minor issue

Steps to Reproduce
-----------------

Perform a subcloud deploy and force a bootstrap failure like modifying registries url or modifying username and password.

Expected Behavior
-----------------

When a bootstrap failure occurs, it is expected to see an accurate and helpful message when using: dcmanager subcloud error <subcloud>

Actual Behavior
-----------------

dcmanager subcloud error proposed action for bootstrap failure suggests the deletion and reinstall of a subcloud, which is not necessary.

Reproducibility
-----------------

100% reproducible

System Configuration
-----------------

DC system with a subcloud

Last Pass
-----------------

n/a

Timestamp/Logs
-----------------

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud errors 3
FAILED bootstrapping playbook of (subcloud1).
detail: fatal: [subcloud1]: FAILED! => changed=true
failed_when_result: true
msg: non-zero return code
stderr: |-
stderr_lines: <omitted>
404 Client Error: Not Found ("manifest unknown: manifest unknown")
HARD FAIL - Image download failed: registry.central:9001/k8s.gcr.io/kube-apiserver:v1.24.4 404 Client Error: Not Found ("manifest for registry.central:9001/k8s.gcr.io/kube-apiserver:v1.24.4 not found: manifest unknown: manifest unknown")
HARD FAIL - Image download failed: registry.central:9001/k8s.gcr.io/kube-controller-manager:v1.24.4 404 Client Error: Not Found ("manifest for registry.central:9001/k8s.gcr.io/kube-controller-manager:v1.24.4 not found: manifest unknown: manifest unknown")
HARD FAIL - Image download failed: registry.central:9001/k8s.gcr.io/kube-scheduler:v1.24.4 404 Client Error: Not Found ("manifest for registry.central:9001/k8s.gcr.io/kube-scheduler:v1.24.4 not found: manifest unknown: manifest unknown")
HARD FAIL - Image download failed: registry.central:9001/k8s.gcr.io/kube-proxy:v1.24.4 404 Client Error: Not Found ("manifest for registry.central:9001/k8s.gcr.io/kube-proxy:v1.24.4 not found: manifest unknown: manifest unknown")
FAILED TASK: TASK [common/push-docker-images : Download images and push to local registry] Wednesday 04 October 2023 19:59:14 +0000 (0:00:00.023) 0:16:34.032
For bootstrap failures, please delete and re-add the subcloud after the cause of failure has been resolved.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/918663

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/918663
Committed: https://opendev.org/starlingx/distcloud/commit/e999c89c520ccc5bb26e0d5f05743b36245b51bb
Submitter: "Zuul (22348)"
Branch: master

commit e999c89c520ccc5bb26e0d5f05743b36245b51bb
Author: Raphael Lima <email address hidden>
Date: Wed May 8 11:32:00 2024 -0300

    Update proposed action in "dcmanager subcloud error" for bootstrap failure

    Update the proposed action displayed by "dcmanager subcloud error"
    command when a subcloud is in bootstrap-failed state.
    Instead of suggesting the deletion and reinstall of the subcloud,
    it should indicate the usage of "dcmanager subcloud deploy resume"
    after the cause of the failure has been resolved.

    Test plan:
    1. PASS: deploy a subcloud with the wrong password in
    bootstrap-values file and verify that the error message
    displayed in "dcmanager subcloud error <subcloud>"
    informs the new proposed action.

    Closes-Bug: 2065189

    Change-Id: Ie41b38c5b527424bdd64ca5af1ed59c91bf03e70
    Signed-off-by: Raphael Lima <email address hidden>