build: uft docker image: no error handling in build script

Bug #2062019 reported by Davlet Panech
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Davlet Panech

Bug Description

Brief Description
-----------------
The build script for uft docker image falsely reports success even when the build fails. This prevents the master build script from retrying the build step in case of intermittent network problems.

https://opendev.org/starlingx/app-intel-ethernet-operator/src/branch/master/uft-image/debian/build-uft-image.sh#L22

Severity
--------
Minor

Steps to Reproduce
------------------
Disconnect from the network and try to build uft using build-stx-images.

Expected Behavior
------------------
Build fails and returns non-zero to the shell

Actual Behavior
----------------
Build succeeds and returns zero to the shell

Reproducibility
---------------
Seen once

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master/2024-04-17

Last Pass
---------
N/A

Timestamp/Logs
--------------

08:44:44 Building uft
08:44:44 get_git 'https://github.com/intel/UFT.git' '43cdc7277897093f7e894bfc103e7ca1fe9edc8c' '/localdisk/designer/jenkins/debian-master/cgcs-root/stx/app-intel-ethernet-operator/uft-image/debian/../files/0001-fix-entrypoint.sh-error.patch
08:44:44 /localdisk/designer/jenkins/debian-master/cgcs-root/stx/app-intel-ethernet-operator/uft-image/debian/../files/0002-uft-image-pin-pyyaml-version-to-avoid-build-errors.patch'
08:44:44 Running: /bin/bash -c rm -rf UFT.clone_tmp && git clone --recursive https://github.com/intel/UFT.git UFT.clone_tmp
<...>
08:44:45 Sending build context to Docker daemon 1.051MB

08:44:45 Step 1/37 : FROM registry.access.redhat.com/ubi8/ubi:8.4
08:45:31 missing or empty Content-Length header
08:45:31 Error response from daemon: No such image: jenkins/uft:master-debian-stable-build
08:45:31 Running: docker push starlingx/uft:master-debian-stable-20240411T060055Z.0

Test Activity
-------------
N/A

Workaround
----------
N/A

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to app-intel-ethernet-operator (master)
Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to app-intel-ethernet-operator (master)

Reviewed: https://review.opendev.org/c/starlingx/app-intel-ethernet-operator/+/916117
Committed: https://opendev.org/starlingx/app-intel-ethernet-operator/commit/2f5f1aa9c433f3221436c003e1f9d7617cf7e3b3
Submitter: "Zuul (22348)"
Branch: master

commit 2f5f1aa9c433f3221436c003e1f9d7617cf7e3b3
Author: Davlet Panech <email address hidden>
Date: Wed Apr 17 10:40:11 2024 -0400

    build-uft-image.sh: error handling

    Exit with non-zeron if "docker build" fails.

    Closes-Bug: 2062019
    Change-Id: If1ce682b99a98c918dd603ad78bc1de519525f84
    Signed-off-by: Davlet Panech <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Low
tags: added: stx.10.0 stx.apps stx.build
Changed in starlingx:
assignee: nobody → Davlet Panech (dpanech)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.