APPLICATION_DOCKER_IMAGE in Remote Client 2.3.3 uses image tag 'latest'

[Erickson Silva de Oliveira]

Brief Description
-----------------
In Remote Client 2.3.3 tarball, 'docker_image_version.sh' has 'latest' image tag for application_docker image. APPLICATION_DOCKER_IMAGE="docker.io/starlingx/stx-openstackclients:master-centos-stable-latest" As using 'latest' tag is widely considered a bad practice, raising this Jira to update this image with appropriate tag. What was 'latest' at the time of releasing 2.3.3 may be different than what's 'latest' when customer is setting up their client, and all sorts of unexpected issues may arise.

Severity
--------
<Minor: System/Feature is usable with minor issue>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/root/+/915027

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/clients/+/915062

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/915027
Committed: https://opendev.org/starlingx/root/commit/c7cdd23b7ec4f0092078a5e214c2084b44e487d6
Submitter: "Zuul (22348)"
Branch: master

commit c7cdd23b7ec4f0092078a5e214c2084b44e487d6
Author: Erickson Silva de Oliveira <email address hidden>
Date: Wed Apr 3 18:06:51 2024 -0300

    Add stx-openstackclients image in tag-mgmt

    The clients repo uses stx-openstackclients image,
    however, the image is not tagged.

    This commit adds the latest build of stx-openstackclients
    in tag-mgmt availability on 04/03/2024:
    https://hub.docker.com/layers/starlingx/stx-openstackclients/master-debian-stable-20240402T160056Z.0/images/sha256-e305f5fb2c2b7a8fbf5a9aacfe3c96a59633e8f6caeba54456ced2309f66945b

    After this review is merged, a new review will be created
    in the 'clients' repository to change the image with the new tag.

    Partial-Bug: 2060161

    Change-Id: I4a2aa31e38c96a23285c1d7821795d5d1f87cb24
    Signed-off-by: Erickson Silva de Oliveira <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/clients/+/915062
Committed: https://opendev.org/starlingx/clients/commit/8167651db995164688cbf6064ce471f856655967
Submitter: "Zuul (22348)"
Branch: master

commit 8167651db995164688cbf6064ce471f856655967
Author: Erickson Silva de Oliveira <email address hidden>
Date: Thu Apr 4 09:58:20 2024 -0300

    Update stx-openstackclients tag to stx.10.0-v1.0.0

    Using the 'latest' tag is widely considered a bad
    practice, so a static tag was created to prevent this:
    https://review.opendev.org/c/starlingx/root/+/915027

    Closes-Bug: 2060161

    Depends-On: https://review.opendev.org/c/starlingx/root/+/915027

    Change-Id: I7a8d1671ea6a48d4f42009bb1a7a4a8c23302974
    Signed-off-by: Erickson Silva de Oliveira <email address hidden>