Subcloud peer group association sync is not updating the bootstrap-address on the secondary site

[Gustavo Herzmann]

Brief Description
-----------------
Subcloud peer group association sync doesn't update the bootstrap-address on the secondary site

Severity
--------
<Major: System/Feature is usable but degraded>

Steps to Reproduce
------------------
Setup the geo-redundancy feature and then:
1 - Update the subclouds bootstrap-address on site 1:
dcmanager subcloud update --bootstrap-address <new_address> subcloud1-sc1-ptg

2 - Run PGA sync:
dcmanager peer-group-association sync <association_id>

3 - Check the rehome_data on the secondary site

Expected Behavior
------------------
The rehome_data should contain the new address

Actual Behavior
----------------
The rehome_data contains the old address

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Distributed cloud system with geo-redundancy

Branch/Pull Time/Commit
-----------------------
master 2024-03-11

Last Pass
---------
This issue was present since the sync operation was first introduced

Timestamp/Logs
--------------
NA

Test Activity
-------------
Feature Testing

Workaround
----------
Remove the subcloud from the subcloud peer group, sync, update the bootstrap address, add the subcloud to the SPG and sync again.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/913271

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/913271
Committed: https://opendev.org/starlingx/distcloud/commit/165dd39c642769ca2378e2c4ff813b962690723c
Submitter: "Zuul (22348)"
Branch: master

commit 165dd39c642769ca2378e2c4ff813b962690723c
Author: Gustavo Herzmann <email address hidden>
Date: Thu Mar 14 18:37:29 2024 -0300

    Fix bootstrap_address parameter name during PGA sync

    This commit changes the bootstrap address parameter from
    "bootstrap-address" to "bootstrap_address" during the subcloud update
    call made during the PGA sync operation. This fixes the issue where
    the bootstrap_address was not being updated on the peer site, as the
    subcloud update API expects the "bootstrap_address" parameter, with
    an underscore.

    Test Plan:
    1. PASS - Create a peer group association and let it do the initial
              sync. Modify the bootstrap-address of the subcloud using
              the subcloud update command and then run the PGA sync
              command. Verify that the rehome_data of the secondary
              subcloud was updated with the new address.

    Closes-Bug: 2057973

    Change-Id: Ib5786a56c90f771b940e740bc095ebc8168d2830
    Signed-off-by: Gustavo Herzmann <email address hidden>