Uninitialized ts2phc variable causes "ignoring invalid master time stamp" error

Bug #2055464 reported by Cole Walker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Cole Walker

Bug Description

Brief Description
-----------------
After configuring and starting the ts2phc application via "system ptp-instance-apply", a system alarm for PTP clocking out-of-tolerance can be raised and does not clear. Logs in /var/log/user.log indicate that ts2phc is unable to synchronize time due to an "ignoring invalid master time stamp" error.

This appears to be the result of an unitialized variable in ts2phc and is corrected by this upstream fix in linuxptp: https://github.com/richardcochran/linuxptp/commit/63fc1ef4fd5e5fc45dd4de3bf27920bb109a4357

Severity
--------
Provide the severity of the defect.
<Major: System/Feature is usable but degraded>

Steps to Reproduce
------------------
Configure ts2phc

system ptp-instance-add ts1 ts2phc
system ptp-interface-add tsint1 ts1
system host-if-ptp-assign controller-0 oam0 tsint1
system host-if-ptp-assign controller-0 data0 tsint1
system ptp-instance-parameter-add ts1 ts2phc.nmea_serialport=/dev/ttyGNSS_5100_0
system host-ptp-instance-assign controller-0 ts1
system host-update controller-0 clock_synchronization=ptp
system ptp-instance-apply

Check ts2phc logs at /var/log/user.log for repeated instances of "ignoring invalid master time stamp"

Expected Behavior
------------------
The ts2phc service should not reject valid timestamps and should sync the configured clocks.

Actual Behavior
----------------
Ts2phc rejects valid timestamps and does not sync configured clocks

Reproducibility
---------------
Intermittent, but can be seen with repeated restarts of ts2phc.

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
Stx master as of 2024-02-09

Last Pass
---------
Unknown

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Developer testing

Workaround
----------
Restart the ts2phc application with "sudo systemctl restart ts2phc@*" and verify operation in /var/log/user.log

Cole Walker (cwalops)
Changed in starlingx:
assignee: nobody → Cole Walker (cwalops)
Ghada Khalil (gkhalil)
tags: added: stx.9.0 stx.networking
Changed in starlingx:
importance: Undecided → Medium
Revision history for this message
Ghada Khalil (gkhalil) wrote (last edit ):

Fixed by: https://review.opendev.org/c/starlingx/integ/+/910822
Merged on March 4

Note: The LP was not updated automatically because the Closes-Bug syntax was incorrect

Changed in starlingx:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.