Need Semantic Check for Reconfiguring Subcloud within SPG

[srana]

Brief Description
-----------------
Subcloud reconfigure can only run while subcloud is managed by the Primary site. Please add semantic check for this subcloud operation.

Severity
--------
Major

Steps to Reproduce
------------------
1. Create the system peer group from Site A to Site B

2. Create System peer from Site B to Site A

3. Create the subcloud peer group in the Site A

4. Assign subcloud(s) to the peer group

5. Create peer group association to associate system peer and subcloud peer group - Site A

- Check: From Site A (primary), make change(s) in the DM config file and reconfig the subcloud.
- Expected result: Verify the reconfig works from the primary site.

6. From Site B, perform the migration of the subcloud through subcloud peer group.

- Check: From Site B (secondary), make change(s) in the DM config file and try to reconfig the subcloud
- Expected result: The reconfig operation should not be allowed from the secondary site (the peer site where subclouds in the SPG can be migrated to.)

Expected Behavior
------------------
Secondary site (the peer site where subclouds in the SPG can be migrated to) cannot reconfig a subcloud.

Actual Behavior
----------------
No currently restricted

Reproducibility
---------------
N/A

System Configuration
--------------------
DC with GR Config (2 Sites)

Branch/Pull Time/Commit
-----------------------
Master

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Evaluation

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/909264

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/909264
Committed: https://opendev.org/starlingx/distcloud/commit/fc0a5f0e53ccac983bbd7ffc681b807e364ced53
Submitter: "Zuul (22348)"
Branch: master

commit fc0a5f0e53ccac983bbd7ffc681b807e364ced53
Author: Salman Rana <email address hidden>
Date: Fri Feb 16 15:00:25 2024 -0500

    Restrict subcloud deploy configure to primary site

    Restrict subcloud's secondary sites (the peer site where
    subcloud in SPG can be migrated to) from reconfiguring
    the subcloud. This is necessary because subcloud reconfig
    may update the OpenStack endpoints/routes/network IPs and impact
    the ability to migrate the subcloud back to the primary site.

    - Introduced a check in "deploy configure" to ensure that
    the target subcloud is managed by its primary site. The site
    status is inferred from the subcloud's peer group priority on the site.

    Test Plan:
    Setup a DC system with GR configuration (2 sites + subclouds) and
    verify the "subcloud deploy config" command with the following arrangements:
    1. PASS: For a subcloud that's not part of protection group
             (not in any SPG / not part of GR),
             ensure that the operation is not restricted.
    2. PASS: Add subcloud to SPG and keep it managed by primary site,
             ensure that the operation is not restricted.
    3. PASS: Add system peer, create SPG association with a secondary
             site, and migrate the subcloud from #2. Verify that "deploy
             config" is restricted and it fails with following error
             message: "Subcloud must be managed by its primary site"
    4. PASS: Using the subcloud from #3, migrate it back to the primary
             site. Attempt to deploy config and ensure that the operation
             is not restricted.

    Closes-Bug: 2054161

    Change-Id: I7e986771a32882bfad917c85439e6f6b99dfe173
    Signed-off-by: Salman Rana <email address hidden>