Tox configuration for distributedcloud-client not setup correctly

Bug #2053023 reported by Hugo Nicodemos Brito
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Hugo Nicodemos Brito

Bug Description

Brief Description
-----------------
The pylint configuration run by tox/zuul ignores code violations like 'line too long' or import order.

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
run tox command

Expected Behavior
------------------
The tox command output gets errors like 'line too long'.

Actual Behavior
----------------
tox pep8/pylint pass

Reproducibility
---------------
<Reproducible>

System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, https, IPv4, IPv6 etc.>

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
NA

Timestamp/Logs
--------------
NA

Test Activity
-------------
NA

Workaround
----------
NA

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud-client (master)
Changed in starlingx:
status: New → In Progress
Changed in starlingx:
assignee: nobody → Hugo Nicodemos Brito (hbrito)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud-client (master)

Reviewed: https://review.opendev.org/c/starlingx/distcloud-client/+/908900
Committed: https://opendev.org/starlingx/distcloud-client/commit/b87508a41011b06637a9c67e51082c55befc0929
Submitter: "Zuul (22348)"
Branch: master

commit b87508a41011b06637a9c67e51082c55befc0929
Author: Hugo Brito <email address hidden>
Date: Tue Feb 13 09:26:07 2024 -0300

    Update tox config for Distributed Cloud Client

    Cleanup the tox configuration and requirements.

    Black formatter was applied in the modified files.

    Test Plan:
    Verify that all Tox tests pass without errors.
    1. Successfully executed on the distributedcloud dir
    - tox -e docs,releasenotes,api-ref,bandit,linters
    - tox -e newnote -- new-note
    2. Successfully executed on the distributedcloud/distributedcloud dir
    - tox -e py39,pylint,pep8,cover

    Partial-Bug: 2053023

    Change-Id: Ib25f31f8607e46e51dfbda0a6b3a36e9e11151df
    Signed-off-by: Hugo Brito <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/starlingx/distcloud-client/+/909454
Committed: https://opendev.org/starlingx/distcloud-client/commit/a507c6449d9bbe3ae02506b27e45272b96635216
Submitter: "Zuul (22348)"
Branch: master

commit a507c6449d9bbe3ae02506b27e45272b96635216
Author: Hugo Brito <email address hidden>
Date: Mon Feb 19 11:48:19 2024 -0300

    Enable R (refactor) checkers on pylint

    This commit enables the `R` (refactor) checkers in `pylint`
    configuration. This will help ensure code maintainability
    and adherence to best practices.

    Black formatter was applied in the modified files.

    Test Plan:
    PASS: Execute tox command
    - pylint success
    - py39 success
    - pep8 success

    Partial-Bug: 2053023

    Change-Id: I9946eaee33e4691fc212a852079ba0ca851a6ccd
    Signed-off-by: Hugo Brito <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/starlingx/distcloud-client/+/909478
Committed: https://opendev.org/starlingx/distcloud-client/commit/1614a6ae75825afd49d996d5a44144ba36da47bd
Submitter: "Zuul (22348)"
Branch: master

commit 1614a6ae75825afd49d996d5a44144ba36da47bd
Author: Hugo Brito <email address hidden>
Date: Mon Feb 19 16:38:08 2024 -0300

    Change class name to use camelCase

    Fixed some class names that were in snake_case because
    it's not right according to PEP8/PyLint. Now they're all camelCase.

    Also, did a direct assignment to client_manager attributes.

    Test Plan:
    PASS: Run tox command.
    - pylint success
    - pep8 success
    - py39 success
    PASS: Check if all commands are working properly.

    Closes-bug: 2053023

    Change-Id: Iba489e23eb27015f27c6b8d5231f5d6002fa6876
    Signed-off-by: Hugo Brito <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Low
tags: added: stx.z
tags: added: stx.9.0 stx.zuul
removed: stx.z
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.