Incorrect system images for K8s 1.25

[Gabriel de Araújo Cabral]

Brief Description
-----------------
some of the container images specified for K8s 1.5 under playbookconfig/src/playbooks/roles/common/load-images-information/vars in the ansible-playbooks git repo are wrong.

Severity
--------
Minor

Steps to Reproduce
------------------
N/A

Expected Behavior
------------------
Correct images being used

Actual Behavior
----------------
In the ansible-playbooks git repo, as of commit ID 0ac2e9a382 the contents of playbookconfig/src/playbooks/roles/common/load-images-information/vars looked like this:

$ ls -l

total 4
Feb 7 12:01 k8s-v1.24.4
Feb 7 12:01 k8s-v1.25.3 -> k8s-v1.26.1
Feb 7 12:01 k8s-v1.26.1
Feb 7 11:02 k8s-v1.27.5 -> k8s-v1.26.1
Dec 7 10:25 main.yml

Then we merged commit a4621fba95, reverted it, and merged commit e91415859f. At this point the contents of the directory looked like this:

$ ls -l

total 4
Feb 7 12:01 k8s-v1.24.4
Feb 7 12:08 k8s-v1.25.3
Feb 7 12:08 k8s-v1.26.1
Feb 7 11:02 k8s-v1.27.5 -> k8s-v1.26.1
Dec 7 10:25 main.yml

The contents of the 1.25.3 folder are buggy at this point.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
All

Branch/Pull Time/Commit
-----------------------
Current dev branch

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Code analysis

Workaround
----------
If install with K8s 1.26 we'll skip over the buggy image versions.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/908518
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/012de70ce8df565fc2a006e5b279af5fe0a0c26c
Submitter: "Zuul (22348)"
Branch: master

commit 012de70ce8df565fc2a006e5b279af5fe0a0c26c
Author: Gabriel de Araújo Cabral <email address hidden>
Date: Thu Feb 8 15:22:47 2024 -0300

    Fix incorrect system images for K8s 1.25

    In the review [1], a new system-images.yml for K8s 1.25 was created,
    replacing a symbolic link that pointed to K8s 1.26.
    The new system-images.yaml for K8s 1.25 was a copy from K8s 1.26,
    with the only difference being the version of the snapshot-controller
    image.

    [1] https://review.opendev.org/c/starlingx/ansible-playbooks/+/887797

    The issue with the K8s 1.25 images arose because, while the review
    was open, some images were updated in the K8s 1.26 system-images.yml,
    which, in the master branch, they were also used for K8s 1.25.
    However, these changes to the images were not reflected in
    the system-images.yaml of K8s 1.25 created in the review that was
    mentioned. Consequently, when merged, K8s 1.25 ended up containing
    the outdated images.

    The current commit updates the images that were impacted on K8s
    1.25.

    Updates missed due to new system-images.yml for K8s 1.25:

    https://review.opendev.org/c/starlingx/ansible-playbooks/+/890987
    https://review.opendev.org/c/starlingx/ansible-playbooks/+/898041
    https://review.opendev.org/c/starlingx/ansible-playbooks/+/899271
    https://review.opendev.org/c/starlingx/ansible-playbooks/+/899982

    Removing the RVMC image as the RVMC script was decontainerized in
    the review:

    https://review.opendev.org/c/starlingx/ansible-playbooks/+/897490

    Test Plan:
     PASS: Run ansible bootstrap playbook with new images on
           k8s 1.25.3 (AIO-SX fresh install with K8s 1.25)
     PASS: Verify all images are downloaded and tagged with
           local registry after installation
     PASS: Check that all pods are healthy and using the
           correct image after installation

    Closes-bug: 2052728

    Change-Id: I269bef9fd679061797e5042263f59cabc2a6e822
    Signed-off-by: Gabriel de Araújo Cabral <email address hidden>