stx-openstack: build downloader failure with openstack-helm and openstack-helm-infra

[Thales Elero Cervi]

Brief Description
-----------------
Last master/debian/openstack build (20240207T170059Z) failed to download source files for openstack-helm and openstack-helm-infra

Severity
--------
Major: Build is broken

Steps to Reproduce
------------------
Inside build environment run:
* downloader -b -s -B std,rt
(to download binary, sources & 3rd-party to local mirror)

Expected Behavior
------------------
Download prerequisites step is completed successfully

Actual Behavior
----------------
Download prerequisites step fails.

Reproducibility
---------------
Reproducible after [1] was merged

Branch/Pull Time/Commit
-----------------------
master/debian/openstack (20240207T170059Z)
after commit 3c29972799e2166aa1dd01a3f98fc88781388524

Last Pass
---------
master/debian/openstack (20240206T170059Z) [2]

Timestamp/Logs
--------------
[2024-02-07T17:34:14.309Z] 2024-02-07 17:34:13,545 - downloader - ERROR: +++++++++++++++++++++++++++++++++++++++++++++++++
[2024-02-07T17:34:14.309Z] 2024-02-07 17:34:13,545 - downloader - ERROR: Failed to download packages: 2
[2024-02-07T17:34:14.309Z] 2024-02-07 17:34:13,545 - downloader - ERROR: openstack-helm
[2024-02-07T17:34:14.309Z] 2024-02-07 17:34:13,545 - downloader - ERROR: openstack-helm-infra
(...)
[Pipeline] End of Pipeline
ERROR: script returned exit code 1
Finished: FAILURE

[2024-02-07T17:32:46.013Z] 2024-02-07 17:32:45,763 - debrepack - ERROR: No such file /localdisk/designer/jenkins/debian-master-openstack/cgcs-root/stx/openstack-armada-app/openstack-helm/files/index.yaml
[2024-02-07T17:32:46.013Z] 2024-02-07 17:32:45,764 - downloader - ERROR:
[2024-02-07T17:32:46.013Z] 2024-02-07 17:32:45,764 - downloader - ERROR: Failed to download source with /localdisk/designer/jenkins/debian-master-openstack/cgcs-root/stx/openstack-armada-app/openstack-helm
[2024-02-07T17:32:46.013Z] 2024-02-07 17:32:45,767 - debrepack - ERROR: No such file /localdisk/designer/jenkins/debian-master-openstack/cgcs-root/stx/openstack-armada-app/openstack-helm-infra/files/repositories.yaml
[2024-02-07T17:32:46.013Z] 2024-02-07 17:32:45,767 - downloader - ERROR:
[2024-02-07T17:32:46.013Z] 2024-02-07 17:32:45,768 - downloader - ERROR: Failed to download source with /localdisk/designer/jenkins/debian-master-openstack/cgcs-root/stx/openstack-armada-app/openstack-helm-infra

Test Activity
-------------
Build

Workaround
----------
Manually recreate the missing files (wrongly removed by accident)

[1] https://opendev.org/starlingx/openstack-armada-app/commit/3c29972799e2166aa1dd01a3f98fc88781388524
[2] https://mirror.starlingx.cengn.ca/mirror/starlingx/master/debian/openstack/20240206T170059Z/logs/download-prerequisites.log.txt

[Thales Elero Cervi (tcervi)]

The removed files are necessary for openstack-helm and openstack-helm-infra packages build:

openstack-helm-infra/debian/meta_data.yaml:
src_files:
  - files/repositories.yaml

openstack-helm/debian/meta_data.yaml
src_files:
  - files/index.yaml
  - files/repositories.yaml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/openstack-armada-app/+/908504

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/openstack-armada-app/+/908504
Committed: https://opendev.org/starlingx/openstack-armada-app/commit/635377335ec00da91dddd0be56a3ceb0bd6babc7
Submitter: "Zuul (22348)"
Branch: master

commit 635377335ec00da91dddd0be56a3ceb0bd6babc7
Author: Lucas de Ataides <email address hidden>
Date: Thu Feb 8 12:09:25 2024 -0300

    Recreating required files for `files` folder

    Commit [1] removed the `files` directory for both openstack-helm and
    openstack-helm-infra folders, as they were not used by the Debian build
    system. However, 3 files were incorrectly removed, causing issues when
    running the downloader command.

    This commit reintroduces these files, making sure the build for both
    packages work.

    [1] https://review.opendev.org/c/starlingx/openstack-armada-app/+/908177

    Test Plan:
    PASS - Successfully run downloader -s -b -B std,rt

    Closes-Bug: 2052709

    Change-Id: I4ee8d11b4c4fc78d570c4ef0f8a9d950dc748aa8
    Signed-off-by: Lucas de Ataides <email address hidden>