patch_builder.py not reading "reboot required" and "unremovable" values

Bug #2052458 reported by Dostoievski Albino Batista
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Dostoievski Albino Batista

Bug Description

Brief Description
-----------------
When patch's recipe contains values set to N in "reboot required" or/and "unremovable" fields, patch_builder.py doesn't not generate the metadata with the correct values.

Severity
--------
Minor

Steps to Reproduce
------------------
Use recipe with fields "reboot required" or/and "unremovable" set to N. e.g.:
[...]
    <reboot_required>N</reboot_required>
    <unremovable>N</unremovable>
[...]

Create patch and check metadata with: tar xf ${PATCH_PATH} | tar x -O
[...]
  <unremovable>Y</unremovable>
  <reboot_required>Y</reboot_required>
[...]

Expected Behavior
------------------
Patch metadata should have same values as set on recipe.

Actual Behavior
----------------
Patch metadata don't have same value as set on recipe.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
N/A

Workaround
----------
N/A

Changed in starlingx:
assignee: nobody → Dostoievski Albino Batista (dalbinob)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to root (master)

Reviewed: https://review.opendev.org/c/starlingx/root/+/907899
Committed: https://opendev.org/starlingx/root/commit/0136ecee29593a74f4a0695b0e69c3e77ef57340
Submitter: "Zuul (22348)"
Branch: master

commit 0136ecee29593a74f4a0695b0e69c3e77ef57340
Author: Dostoievski Batista <email address hidden>
Date: Mon Feb 5 15:06:53 2024 -0300

    Fix "reboot_required" and "unremovable" values inside metadata

    This commits change metadata.py to correctly
    read the values set on recipe's fields "reboot_required"
    and "unremovable" when creating a patch.

    Test Plan:
        PASS: Generate patch with "reboot_required" and
        "unremovable" set as "N".
        PASS: Generate patch with "reboot_required" and
        "unremovable" set as "Y".

    Closes-bug: 2052458

    Change-Id: I9ba5058b296a63d98685882cee66ef6aa21c4f02
    Signed-off-by: Dostoievski Batista <email address hidden>

Changed in starlingx:
status: New → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Low
tags: added: stx.9.0 stx.update
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.