build: nginx-ingress-controller-armada-app: source tarball URL checksum mismatch

[Davlet Panech]

Brief Description
-----------------

The source tarball referenced in debian build recipe of starlingx/nginx-ingress-controller-armada-app has a checksum that doesn't match the upstream file from github. It seems the tag got moved on github.com since its checksum was recorded in starlingx. The github's tag appears wrong now since it includes things that aren't part of that tag/release.

We need to update the URL in meta_data.yaml to point to a copy of this file that exists on StarlingX public mirror, ie:

This file with the same checksum does exist on the mirror, ie: https://mirror.starlingx.windriver.com/mirror/debian/github.com/kubernetes/ingress-nginx/archive/controller-v1.9.3.tar.gz

Severity
--------
Major

Steps to Reproduce
------------------
(approximate steps)

* Manually delete the helm charts tarball from "mirrors/", if it exists:
mirrors/starlingx/downloads/helm-charts-ingress-nginx-1.9.3.tar.gz

* Re-run downloader

* (Re-)build package stx-nginx-ingress-controller-helm:

build-pkgs -c stx-nginx-ingress-controller-helm

Expected Behavior
------------------
Build works

Actual Behavior
----------------
Build fails (??)

Reproducibility
---------------
N/A

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master/2024-01-31

Last Pass
---------
Unknown

Timestamp/Logs
--------------
N/A

Test Activity
-------------
N/A

Workaround
----------
N/A

[Davlet Panech (dpanech)]

Ie change the URL on this line:

https://opendev.org/starlingx/nginx-ingress-controller-armada-app/src/branch/master/stx-nginx-ingress-controller-helm/debian/meta_data.yaml#L8

to point to the mirror file, https://mirror.starlingx.windriver.com/mirror/debian/github.com/kubernetes/ingress-nginx/archive/controller-v1.9.3.tar.gz

[Davlet Panech (dpanech)]

<email address hidden> wrote:

I think github is broken, the tarball for nginx controller is broken:

cgcs-root/stx/nginx-ingress-controller-armada-app$ cat stx-nginx-ingress-controller-helm/debian/meta_data.yaml
<snip>
dl_files:
  helm-charts-ingress-nginx-1.9.3.tar.gz:
    topdir: helm-charts
    url: https://github.com/kubernetes/ingress-nginx/archive/controller-v1.9.3.tar.gz
    md5sum: e26752857ac5f083a7b0fcba7ec9a81f

$ wget https://github.com/kubernetes/ingress-nginx/archive/controller-v1.9.3.tar.gz
$ md5sum controller-v1.9.3.tar.gz
80895dcb4909c8199876f95d17a0ff40 controller-v1.9.3.tar.gz

If I find an old correct copy (e26752857ac5f083a7b0fcba7ec9a81f md5sum) of the tarball, I can see some changes in the 80895dcb4909c8199876f95d17a0ff40 md5sum file that are garbage, such as a reversion to 1.9.1 in the chart appVersion:

-appVersion: 1.9.3
+appVersion: 1.9.1

So, that v1.9.3 tag in github seems broken.

[Davlet Panech (dpanech)]

Also: you may need to set "stx_mirror_strategy = upstream" in stx.conf & restart your build environment to trigger this failure.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/nginx-ingress-controller-armada-app/+/907487

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/nginx-ingress-controller-armada-app/+/907487
Committed: https://opendev.org/starlingx/nginx-ingress-controller-armada-app/commit/bcfdb886947f2d20956741d75a7ee793e231eb90
Submitter: "Zuul (22348)"
Branch: master

commit bcfdb886947f2d20956741d75a7ee793e231eb90
Author: amantri <email address hidden>
Date: Thu Feb 1 14:07:42 2024 -0500

    Change nginx upstream tarball url reference to stx mirror

    Upstream/3rd-party (GitHub.com) git tag got moved by that project's
    authors which is breaking the build, so changing the reference
    for nginx tag/tarball from upstream to the stx mirror

    Test Cases:
    PASS: After change, build nginx pkg with "build-pkgs -c -p stx-nginx-
          ingress-controller-helm" and verify that nginx pkg is
          successfully built

    Closes-bug: 2051963

    Change-Id: I7e55208581860774bab7475e569dbb24ac40cebe
    Signed-off-by: amantri <email address hidden>