Missing guestServer.conf is linked into /etc/pmon.d

[Eric MacDonald]

Brief Description:

The guestServer daemon is no longer used on worker nodes.

However the code base is still creating a pmon config file for it in /etc/pmon.d

The code that creates this link in /etc/pmon.d needs to be removed.

 guestServer.conf -> /usr/share/starlingx/pmon.d/guestServer.conf

Severity:

Minor issue. No real impact. Its just wrong.

Steps to Reproduce:

Install any system

Expected Behavior:

no invalid links in /etc/pmon.d

Actual Behavior:

There is an invalid guestServer.conf link in /etc/pmon.d

Reproducibility:

100% reproducible

System Configuration:

Worker nodes only ; AIO or worker

Load info (eg: 2022-03-10_20-00-07)

Any 23.09 or later images

Last Pass:

Prior to guestServer daemon having been removed from workers

Timestamp/Logs:

2024-01-25T08:39:09.376 [62268.00046] compute-0 pmond mon pmonHdlr.cpp ( 579) process_config_load :Error : Read Failure : /etc/pmon.d/guestServer.conf

Alarms:

None

Test Activity:

Developer Testing

Workaround:

None Required

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/907213

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/907213
Committed: https://opendev.org/starlingx/metal/commit/5a3a5ce8ea77f840c416361caf47fbed98485ac4
Submitter: "Zuul (22348)"
Branch: master

commit 5a3a5ce8ea77f840c416361caf47fbed98485ac4
Author: Eric MacDonald <email address hidden>
Date: Tue Jan 30 14:41:41 2024 +0000

    Stop creating guestServer.conf /etc/pmon.d link

    The maintenance guestServer daemon has been deprecated for quite
    some time.

    However, that deprecation process left the kickstarts creating a
    dangling link to a missing guestServer.conf in the /etc/pmon.d
    directory.

    Pmon just ignores the missing process so there is no service impact.

    This update cleans this up by removing the code in the kickstarts
    that create the dangling link.

    Test Plan:

    PASS: Verify the guestServer.conf dangling link no longer exists
          in worker nodes.
    PASS: Verify pmond.log makes no mention of the deprecated guestServer
          process.

    Closes-Bug: 2051389
    Change-Id: I89a62d939194c65c86e3cf71b238698eb2ee97ed
    Signed-off-by: Eric MacDonald <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/integ/+/907431

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/integ/+/907431
Committed: https://opendev.org/starlingx/integ/commit/b5ef59fc8ed4148e4458de97b7a6108297fc567f
Submitter: "Zuul (22348)"
Branch: master

commit b5ef59fc8ed4148e4458de97b7a6108297fc567f
Author: Eric MacDonald <email address hidden>
Date: Wed Jan 31 19:19:05 2024 +0000

    Remove guestServer and guestAgent from systemd-presets

    The stx/nfv/mtce-guest service has been deprecated and is no longer
    built as part of the nfv git.

    https://opendev.org/starlingx/nfv/commit/
    bfded2ded62263695ec37fb6214eda7b191c1cbc

    However, removing the guestServer and guestAgent systemd presets
    were missed.

    Therefore, as a final cleanup effort for these deprecated
    services, this update removes all references to both the
    guestAgent and guestServer from starlingX systemd-presets.

    Test Plan:

    PASS: Full clean Debian build
    PASS: Debian ISO install Standard system with worker and storage
    PASS: Verify guestServer and guestAgent service files are not packaged.

    Related-Bug: 2051389
    Change-Id: I4b0dfa1739f35b0ceab3b6b98a9b24eb53caa1a9
    Signed-off-by: Eric MacDonald <email address hidden>