IPv4 subcloud deployment failure with Bond interfaces

[Mohammad Issa]

Brief Description
-----------------
Subcloud deployments are failing because the conductor could not reach one of the oam vlan IP, but can after reboot.

Severity
--------
Major: Subcloud deployment fails and needs to be rebooted before getting stable

Steps to Reproduce
------------------
Create a subcloud deployment with a bond interface.

Expected Behavior
------------------
Subcloud vlan comes up with the specified bond name in DM config.

Actual Behavior
----------------
Subcloud vlan coming up with bootstrap interface instead of bond interface

Reproducibility
---------------
Reproducible 100% for ipv4 simplex.

System Configuration
--------------------
Distributed Cloud

Last Pass
---------
-

Timestamp/Logs
--------------

Test Activity
-------------
Developer Testing (Unit Test)

Workaround
----------
After the reboot, the conf changes to the desired naming and the connectivity between the conductor and subcloud is resolved.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/906007

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/906007
Committed: https://opendev.org/starlingx/metal/commit/efe618fae3e519fa9b2ef5f4b4bcb8ff8ad0e681
Submitter: "Zuul (22348)"
Branch: master

commit efe618fae3e519fa9b2ef5f4b4bcb8ff8ad0e681
Author: Mohammad Issa <email address hidden>
Date: Wed Jan 17 21:15:41 2024 +0000

    IPv4 subcloud failure due to miniboot config

    systemd unable to bring up OAM bonded VLAN IF due to miniboot cfg.

    The autoconf and accept_ra sysctl parameters do not exist for IPv4.
    The accept_redirects does, but in normal operation we only set
    these for IPv6.

    Testing:
    - Build successful
    - Successfully bring up IPv4 System Controller & Subcloud
    - Verify that ifcfg-<ifname> under interfaces.d shows
      that the sysctl parameters are set to ipv6
    - Verify these tests using a miniboot installed IPv4 subcloud

    Closes-Bug: 2049683

    Change-Id: Ib27f86f707796682a3db6641824f9fdbe2f53534
    Signed-off-by: Mohammad Issa <email address hidden>