Backup & Restore after platfoprm upgrade failing

[Erickson Silva de Oliveira]

Brief Description
-----------------
After upgrade successufuly from stx.7.0 to stx.8.0, the backup & restore didn't work properly.

Severity
--------
Minor

Steps to Reproduce
------------------
Upgrade stx.7.0 to stx.8.0
Run backup & restore after finishing the upgrade and the system is operational.

Expected Behavior
------------------
Restore works properly.

Actual Behavior
----------------
Ansible returns an error.

Reproducibility
---------------
Reproduced two times.

System Configuration
--------------------
AIO-DX DC with multipath and subcloud 2+2+2

Timestamp/Logs
--------------
TASK [recover-ceph-data : Add controller monitor into monmap file] ****************************************************
Thursday 07 December 2023 20:10:55 +0000 (0:00:00.333) 0:46:13.219 *****
fatal: [localhost]: FAILED! => changed=true
  cmd:
  - monmaptool
  - --add
  - controller
  - /tmp/monmap
  delta: '0:00:00.014435'
  end: '2023-12-07 20:10:55.464669'
  msg: non-zero return code
  rc: 255
  start: '2023-12-07 20:10:55.450234'
  stderr: 'monmaptool: invalid ip:port ''/tmp/monmap'''
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/905266
Committed: https://opendev.org/starlingx/stx-puppet/commit/b17f59ebcb913e1625390637025e4395bfd2d257
Submitter: "Zuul (22348)"
Branch: master

commit b17f59ebcb913e1625390637025e4395bfd2d257
Author: Erickson Silva de Oliveira <email address hidden>
Date: Wed Jan 10 16:35:02 2024 -0300

    Add 'public_addr' in ceph.conf by default

    After upgrading the platform on AIO-DX, the ceph configuration
    file (/etc/ceph/ceph.conf) is missing the "public_addr" field,
    which causes the playbook to fail when performing backup & restore.

    The problem is caused because this field is defined in the ceph
    puppet, only in the monitor configuration, and during the upgrade
    it does not enter this part, precisely because the host being
    upgraded is not the active controller.

    To resolve this, this field is defined together with the
    "host" field in the initial ceph configuration.

      PASS: (AIO-DX) Upgrade stx.7.0 to stx.8.0
      PASS: Check that public_addr is present in ceph.conf on
            both controllers.
      PASS: Run backup & restore

    Closes-Bug: 2049047

    Change-Id: Ibac139fdf6d86d44f8efca1ca96f5123d639f77c
    Signed-off-by: Erickson Silva de Oliveira <email address hidden>