Upgrade: 76-remove-armada-if-unused.py - Positional argument error when running

[David Barbosa Bastos]

Brief Description
-----------------
A new mandatory argument was added to the registry_image.list method in the cgts sysinv client breaking the contract on 76-remove-armada-if-unused.py thus resulting in a TypeError exception.

Severity
--------
Critical

Steps to Reproduce
------------------
Upgrade from 22.12 prestaging to master. Found during the upgrade-activate step

Expected Behavior
------------------
upgrade-activate step should finish successfully.

Actual Behavior
----------------
upgrade-activate step fails.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
VDM AIO-SX

Branch/Pull Time/Commit
-----------------------
SW_VERSION="23.09"
BUILD_TARGET="Unknown"
BUILD_TYPE="Informal"
BUILD_ID="n/a"

Last Pass
---------
During 76-remove-armada-if-unused.py tests for https://review.opendev.org/c/starlingx/config/+/890651

Timestamp/Logs
--------------
2023-12-20T10:02:27.352 controller-0 configassistant[103374] err /etc/upgrade.d/76-remove-armada-if-unused.py:410 ERROR [__main__] list() missing 1 required positional argument: 'filter_out_untagged'
Traceback (most recent call last):
  File "/etc/upgrade.d/76-remove-armada-if-unused.py", line 400, in main
    if not remove_docker_images():
  File "/etc/upgrade.d/76-remove-armada-if-unused.py", line 315, in remove_docker_images
    image_list = client.sysinv.registry_image.list()
TypeError: list() missing 1 required positional argument: 'filter_out_untagged'

Test Activity
-------------
Developer Testing

Workaround
----------
Remove script 76 from /etc/upgrade.d and re-run upgrade-activate

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/904384
Committed: https://opendev.org/starlingx/config/commit/77f2c9ce3d16fa43c51bf73d22defc4754f292c5
Submitter: "Zuul (22348)"
Branch: master

commit 77f2c9ce3d16fa43c51bf73d22defc4754f292c5
Author: dbarbosa <email address hidden>
Date: Wed Dec 27 11:53:50 2023 -0300

    Fix positional argument error when running the 76 script.

    A new mandatory argument was added to the registry_image.list
    method in the cgts sysinv client breaking the contract on
    76-remove-armada-if-unused.py thus resulting in a TypeError
    exception.

    This commit adds the missing parameter and fixes the error.

    Test Plan:
    PASS Build pkgs and build image
    PASS Upgrade SX stx-8 -> master
    PASS Armada removed when there are no Armada apps

    Closes-Bug: 2047643

    Change-Id: I16a8cc4ed6c12751fc3f90c7c12499914cf6aa52
    Signed-off-by: David Bastos <email address hidden>

[Ghada Khalil (gkhalil)]

Marking as Low priority as there is no official support for upgrades in stx; it's best effort only.