Even unmanaged subclouds can be added to subcloud peer group

[TaoWang]

Brief Description

Even unmanaged subclouds can be added to subcloud peer group.

Severity

Minor

Steps to Reproduce

1) Check the subcloud status

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud list
--------------------------------------------------------------------------------------+

id name management availability deploy status sync backup status backup datetime
--------------------------------------------------------------------------------------+

 2 subcloud5 managed online complete in-sync None None
 8 subcloud3 unmanaged offline bootstrap-failed unknown None None
--------------------------------------------------------------------------------------+

2) Add into the SPG and run PGA:

3) Check on the peer site

[sysadmin@controller-0 dcmanager(keystone_admin)]$ dcmanager subcloud list --all
------------------------------------------------------------------------------------+

id name management availability deploy status sync backup status backup datetime
------------------------------------------------------------------------------------+

 5 subcloud5 unmanaged offline secondary unknown None None
 6 subcloud3 unmanaged offline secondary unknown None None
------------------------------------------------------------------------------------+

Expected Behavior

Should able to add only managed, online and complete status in the SPG

Actual Behavior

Able to add any status subcloud in the SPG

Reproducibility

Yes

Load info (eg: 2022-03-10_20-00-07)

sysadmin@controller-0:~$ cat /etc/build.info
SW_VERSION="23.09"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="2023-12-15_19-00-10"
SRC_BUILD_ID="1605"

BUILD_BY="jenkins"
BUILD_NUMBER="589"
BUILD_HOST="yow-wrcp-lx.wrs.com"
BUILD_DATE="2023-12-16 00:00:10 +0000"

Last Pass

Timestamp/Logs

Alarms

Test Activity

Feature Testing

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/903420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/903420
Committed: https://opendev.org/starlingx/distcloud/commit/717ff7971da4037e258d8bd3bf3d6224f82ef5bd
Submitter: "Zuul (22348)"
Branch: master

commit 717ff7971da4037e258d8bd3bf3d6224f82ef5bd
Author: twang4 <email address hidden>
Date: Thu Dec 21 09:03:18 2023 +0800

    Disallow assigning an unmanaged subcloud to peer group

    Request to add an unmanaged subcloud will be rejected.

    Test plan:
    - PASS: Verify that a managed/online/complete/prestage-complete
            subcloud can be added to the subcloud peer group.
    - PASS: Verify that an offline or unmanaged subcloud cannot be
            added to the subcloud peer group.

    Closes-Bug: 2047066

    Signed-off-by: Wang Tao <email address hidden>
    Change-Id: Ie339f6645e7c42966af395dfa87a81898b1f0af7