Able to add a local subcloud to a subcloud peer group created on another system peer

Bug #2046850 reported by TaoWang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
TaoWang

Bug Description

Brief Description

Able to add a local subcloud to a subcloud peer group created on another system peer.

Severity

Major

Steps to Reproduce

Site A Artifacts

Created peer group association to associate system peer and subcloud peer group - Site A

==Site-A==
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager system-peer list
+----+--------------------------------------+-------------------------+---------------------------------------+----------------------------+
| id | peer uuid | peer name | manager endpoint | controller gateway address |
+----+--------------------------------------+-------------------------+---------------------------------------+----------------------------+
| 2 | c6d2b1d1-2800-41af-b8b0-7b42985e8dd1 | SiteA-SiteB-system-peer | http://[2620:10a:a001:d41::1180]:5000 | fdff:719a:bf60:1103::1 |
+----+--------------------------------------+-------------------------+---------------------------------------+----------------------------+
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager system-peer show 2
+-------------------------------+---------------------------------------+
| Field | Value |
+-------------------------------+---------------------------------------+
| id | 2 |
| peer uuid | c6d2b1d1-2800-41af-b8b0-7b42985e8dd1 |
| peer name | SiteA-SiteB-system-peer |
| manager endpoint | http://[2620:10a:a001:d41::1180]:5000 |
| manager username | admin |
| controller gateway address | fdff:719a:bf60:1103::1 |
| administrative state | enabled |
| heartbeat interval | 60 |
| heartbeat failure threshold | 3 |
| heartbeat failure policy | alarm |
| heartbeat maintenance timeout | 600 |
| heartbeat status | alive |
| created_at | 2023-12-09 15:50:29.724943 |
| updated_at | 2023-12-09 15:57:26.712252 |
+-------------------------------+---------------------------------------+
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud-peer-group list
+----+---------------------------+----------------+-------------+--------------------------------------+--------------------------------+-----------------------+----------------------------+------------+
| id | peer_group_name | group_priority | group_state | system_leader_id | system_leader_name | max_subcloud_rehoming | created_at | updated_at |
+----+---------------------------+----------------+-------------+--------------------------------------+--------------------------------+-----------------------+----------------------------+------------+
| 2 | SiteA-subcloud-peer-group | 0 | enabled | c415889e-3ee6-4cfc-9fe3-fd126e646e4a | wrcpeng-dc40-system-controller | 10 | 2023-12-09 15:52:09.366241 | None |
+----+---------------------------+----------------+-------------+--------------------------------------+--------------------------------+-----------------------+----------------------------+------------+
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud-peer-group list-subclouds 2
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
| id | name | description | location | software_version | management | availability | deploy_status | management_subnet | management_start_ip | management_end_ip | management_gateway_ip | systemcontroller_gateway_ip | group_id | peer_group_id | created_at | updated_at | backup_status | backup_datetime |
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
| 1 | subcloud3 | None | None | 23.09 | managed | online | complete | fdff:719a:bf60:1099::/64 | fdff:719a:bf60:1099::2 | fdff:719a:bf60:1099::ffff | fdff:719a:bf60:1099::1 | fdff:719a:bf60:1096::1 | 1 | 2 | 2023-12-08 22:15:02.419286 | 2023-12-11 07:46:35.418532 | None | None |
| 2 | subcloud5 | None | None | 23.09 | managed | online | complete | fdff:719a:bf60:1106::/64 | fdff:719a:bf60:1106::2 | fdff:719a:bf60:1106::ffff | fdff:719a:bf60:1106::1 | fdff:719a:bf60:1096::1 | 1 | 2 | 2023-12-08 22:16:43.041407 | 2023-12-11 07:46:28.590198 | None | None |
| 3 | subcloud4 | None | None | 23.09 | managed | online | complete | fdff:719a:bf60:1109::/64 | fdff:719a:bf60:1109::2 | fdff:719a:bf60:1109::ffff | fdff:719a:bf60:1109::1 | fdff:719a:bf60:1096::1 | 1 | 2 | 2023-12-08 22:17:21.366654 | 2023-12-11 07:46:45.906297 | None | None |
| 4 | subcloud2 | None | None | 23.09 | managed | online | complete | fdff:719a:bf60:1098::/64 | fdff:719a:bf60:1098::2 | fdff:719a:bf60:1098::ffff | fdff:719a:bf60:1098::1 | fdff:719a:bf60:1096::1 | 1 | 2 | 2023-12-09 05:41:25.719531 | 2023-12-11 07:46:53.404087 | None | None |
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager peer-group-association list
+----+---------------+----------------+---------------------+-------------+
| id | peer_group_id | system_peer_id | peer_group_priority | sync_status |
+----+---------------+----------------+---------------------+-------------+
| 1 | 2 | 2 | 1 | synced |
+----+---------------+----------------+---------------------+-------------+
[sysadmin@controller-0 ~(keystone_admin)]$
Site B artifacts:

Create non-primary peer group association to monitor the peer group.

===Site B===
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager system-peer list
+----+--------------------------------------+-------------------------+---------------------------------------+----------------------------+
| id | peer uuid | peer name | manager endpoint | controller gateway address |
+----+--------------------------------------+-------------------------+---------------------------------------+----------------------------+
| 2 | c415889e-3ee6-4cfc-9fe3-fd126e646e4a | SiteB-SiteA-system-peer | http://[2620:10a:a001:d41::1080]:5000 | fdff:719a:bf60:1109::1 |
+----+--------------------------------------+-------------------------+---------------------------------------+----------------------------+
[sysadmin@controller-0 ~(keystone_admin)]$
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud-peer-group list
+----+---------------------------+----------------+-------------+--------------------------------------+--------------------------------+-----------------------+----------------------------+------------+
| id | peer_group_name | group_priority | group_state | system_leader_id | system_leader_name | max_subcloud_rehoming | created_at | updated_at |
+----+---------------------------+----------------+-------------+--------------------------------------+--------------------------------+-----------------------+----------------------------+------------+
| 2 | SiteA-subcloud-peer-group | 1 | enabled | c415889e-3ee6-4cfc-9fe3-fd126e646e4a | wrcpeng-dc40-system-controller | 10 | 2023-12-10 09:25:29.742170 | None |
+----+---------------------------+----------------+-------------+--------------------------------------+--------------------------------+-----------------------+----------------------------+------------+
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud-peer-group list-subclouds 2
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
| id | name | description | location | software_version | management | availability | deploy_status | management_subnet | management_start_ip | management_end_ip | management_gateway_ip | systemcontroller_gateway_ip | group_id | peer_group_id | created_at | updated_at | backup_status | backup_datetime |
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
| 7 | subcloud5 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1106::/64 | fdff:719a:bf60:1106::2 | fdff:719a:bf60:1106::ffff | fdff:719a:bf60:1106::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:28.949383 | 2023-12-11 07:48:37.126118 | None | None |
| 8 | subcloud3 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1099::/64 | fdff:719a:bf60:1099::2 | fdff:719a:bf60:1099::ffff | fdff:719a:bf60:1099::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:28.976495 | 2023-12-11 07:48:38.134900 | None | None |
| 9 | subcloud2 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1098::/64 | fdff:719a:bf60:1098::2 | fdff:719a:bf60:1098::ffff | fdff:719a:bf60:1098::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:29.011433 | 2023-12-11 07:48:39.568170 | None | None |
| 10 | subcloud4 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1109::/64 | fdff:719a:bf60:1109::2 | fdff:719a:bf60:1109::ffff | fdff:719a:bf60:1109::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:29.037062 | 2023-12-11 07:48:36.756993 | None | None |
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
3. Update the local subcloud to add in the SPG (Site B)

==site B==
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud update --peer-group 2 subcloud7
+-----------------------------+----------------------------+
| Field | Value |
+-----------------------------+----------------------------+
| id | 1 |
| name | subcloud7 |
| description | None |
| location | None |
| software_version | 23.09 |
| management | managed |
| availability | online |
| deploy_status | complete |
| management_subnet | fdff:719a:bf60:4065::/64 |
| management_start_ip | fdff:719a:bf60:4065::2 |
| management_end_ip | fdff:719a:bf60:4065::ffff |
| management_gateway_ip | fdff:719a:bf60:4065::1 |
| systemcontroller_gateway_ip | fdff:719a:bf60:1103::1 |
| group_id | 1 |
| peer_group_id | 2 |
| created_at | 2023-12-09T00:16:27.504767 |
| updated_at | 2023-12-11T07:55:50.982209 |
| backup_status | None |
| backup_datetime | None |
+-----------------------------+----------------------------+
[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud-peer-group list-subclouds 2
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
| id | name | description | location | software_version | management | availability | deploy_status | management_subnet | management_start_ip | management_end_ip | management_gateway_ip | systemcontroller_gateway_ip | group_id | peer_group_id | created_at | updated_at | backup_status | backup_datetime |
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
| 1 | subcloud7 | None | None | 23.09 | managed | online | complete | fdff:719a:bf60:4065::/64 | fdff:719a:bf60:4065::2 | fdff:719a:bf60:4065::ffff | fdff:719a:bf60:4065::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-09 00:16:27.504767 | 2023-12-11 07:55:50.982209 | None | None |
| 7 | subcloud5 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1106::/64 | fdff:719a:bf60:1106::2 | fdff:719a:bf60:1106::ffff | fdff:719a:bf60:1106::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:28.949383 | 2023-12-11 07:48:37.126118 | None | None |
| 8 | subcloud3 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1099::/64 | fdff:719a:bf60:1099::2 | fdff:719a:bf60:1099::ffff | fdff:719a:bf60:1099::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:28.976495 | 2023-12-11 07:48:38.134900 | None | None |
| 9 | subcloud2 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1098::/64 | fdff:719a:bf60:1098::2 | fdff:719a:bf60:1098::ffff | fdff:719a:bf60:1098::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:29.011433 | 2023-12-11 07:48:39.568170 | None | None |
| 10 | subcloud4 | | | 23.09 | unmanaged | offline | secondary | fdff:719a:bf60:1109::/64 | fdff:719a:bf60:1109::2 | fdff:719a:bf60:1109::ffff | fdff:719a:bf60:1109::1 | fdff:719a:bf60:1103::1 | 1 | 2 | 2023-12-11 07:48:29.037062 | 2023-12-11 07:48:36.756993 | None | None |
+----+-----------+-------------+----------+------------------+------------+--------------+---------------+--------------------------+------------------------+---------------------------+------------------------+-----------------------------+----------+---------------+----------------------------+----------------------------+---------------+-----------------+
[sysadmin@controller-0 ~(keystone_admin)]$

Expected Behavior

Only the subclouds which needs to be migrated should be part of the SPG.

Actual Behavior

Able to add the local subcloud on the SPG

Reproducibility

Yes

Load info (eg: 2022-03-10_20-00-07)

[sysadmin@controller-0 ~(keystone_admin)]$ cat /etc/build.info
SW_VERSION="23.09"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="2023-11-30_19-27-37"
SRC_BUILD_ID="1559"

JOB="wrcp-master-debian"
BUILD_BY="jenkins"
BUILD_NUMBER="574"
BUILD_HOST="yow-wrcp-lx.wrs.com"
BUILD_DATE="2023-12-01 00:27:37 +0000"

Last Pass

Timestamp/Logs

Alarms

None

Test Activity

Feature Testing

Workaround

NA

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/903417

Changed in starlingx:
status: New → In Progress
TaoWang (twang4)
Changed in starlingx:
assignee: nobody → TaoWang (twang4)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master)

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/903417
Committed: https://opendev.org/starlingx/distcloud/commit/f15c6b617c718adc06469670365e1a67f6f544af
Submitter: "Zuul (22348)"
Branch: master

commit f15c6b617c718adc06469670365e1a67f6f544af
Author: twang4 <email address hidden>
Date: Tue Dec 19 11:49:01 2023 +0800

    Disallow assign a subcloud to non-zero priority peer group

    If a PEER_GROUP's priority is non-zero,
    disallow CLI call:
    dcmanager subcloud update SUBCLOUD --peer-group
    PEER_GROUP

    Test plan:
    - PASS: update subcloud to a peer-group with non-zero
           priority from CLI failed
    - PASS: update subcloud to a peer-group with non-zero
           priority from API success
    - PASS: update subcloud to a peer-group with zero
           priority from CLI/API success

    Closes-Bug: 2046850

    Signed-off-by: Wang Tao <email address hidden>
    Change-Id: Ie0adfd56611f3080ed607a35b809a9e77865182d

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
tags: added: stx.9.0 stx.distcloud
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.