DC: gen-prestaged-iso.sh --kickstart-patch expects a kickstart file not a patch

[Christopher de Oliveira Souza]

Brief Description

The switch for ./gen-prestaged-iso.sh --kickstart-patch is implemented entirely different than what the switch name and help text would suggest.

Help text:

--kickstart-patch <kickstart-enabler.patch>:
                         A patch to replace the prestaged installer kickstart.
                         Not to be included in the runtime patches.

In fact, it doesn't take a .patch file at all. It wants a path to a kickstart.cfg file.

This is in contrast to the CentOS builds, where it would take a path to a patch file.

Severity

<Minor: System/Feature is usable with minor issue>

 ++

Reproducibility

Reproducible

Load info (eg: 2022-03-10_20-00-07)

22.12

Last Pass

Day 1 issue in Debian

Test Activity

 Developer Testing

Workaround

Provide a path to a kickstart.cfg file to be used in place of the file from the original ISO.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/utilities/+/903745

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/903745
Committed: https://opendev.org/starlingx/utilities/commit/2a6decbb7ff0ccdd138aaceb00c3b58c4a45d877
Submitter: "Zuul (22348)"
Branch: master

commit 2a6decbb7ff0ccdd138aaceb00c3b58c4a45d877
Author: Christopher de Oliveira Souza <email address hidden>
Date: Fri Dec 15 06:57:11 2023 -0300

    Update gen-prestaged-iso.sh help text

    Update the the help text for the --kickstart-patch parameter
    that requires a kickstart.cfg and not a patch file.

    Test Plan:
    PASS: run ./gen-prestaged-iso.sh -h and verify that the help message
    is updated.

    Closes-bug: 2046536

    Change-Id: I6829d62a5c6bbaee1457eebf002a420e315fc432
    Signed-off-by: Christopher de Oliveira Souza <email address hidden>