Bootstrap failed when bootstrap_registry_filesystem_fqpn specified

[Yuxing]

Brief Description

Ansible bootstrap playbook failed when bootstrap_registry_filesystem_fqpn specified

TASK [bootstrap/prepare-env : Ensure that the specified bootstrap registry filesystem exists] **********************************************************************************************************************************************************************************************
Tuesday 04 December 2012 04:44:50 +0000 (0:00:03.510) 0:00:18.498 ******
fatal: [localhost]: FAILED! => changed=false
  msg: 'Invalid options for fail: when'

PLAY RECAP *********************************************************************************************************************************************************************************************************************************************************************************
localhost : ok=48 changed=7 unreachable=0 failed=1 skipped=74 rescued=0 ignored=0
Severity

Minor

Steps to Reproduce

Bootstrap dx system with:
ansible-playbook /usr/share/ansible/stx-ansible/playbooks/bootstrap.yml -e "bootstrap_registry_filesystem_fqpn=$HOME/localhost_image_registry_backup.tgz"
Expected Behavior

Bootstrap succeeded

Actual Behavior

Bootstrap failed due to syntax error

Reproducibility

Reproducible

System Configuration

VM system controller

Load info (eg: 2022-03-10_20-00-07)

stx master load

Last Pass

NA

Timestamp/Logs
TASK [bootstrap/prepare-env : Ensure that the specified bootstrap registry filesystem exists] **********************************************************************************************************************************************************************************************
Tuesday 04 December 2012 04:44:50 +0000 (0:00:03.510) 0:00:18.498 ******
fatal: [localhost]: FAILED! => changed=false
  msg: 'Invalid options for fail: when'

PLAY RECAP *********************************************************************************************************************************************************************************************************************************************************************************
localhost : ok=48 changed=7 unreachable=0 failed=1 skipped=74 rescued=0 ignored=0
Alarms

No

Test Activity

Developer testing

Workaround

NA

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/902717

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/902717
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/8dc965ed262eb4038f424ca5b527633f1bc51e7a
Submitter: "Zuul (22348)"
Branch: master

commit 8dc965ed262eb4038f424ca5b527633f1bc51e7a
Author: Yuxing Jiang <email address hidden>
Date: Tue Dec 5 14:17:30 2023 -0500

    Fix error when bootstrapping with bootstrap_registry_filesystem_fqpn

    This commit fixes a syntax error when using a registry filesystem
    backup to bootstrap the system.

    Test plan:
    1. Passed - bootstrap an AIOSX w/o bootstrap_registry_filesystem_fqpn.
    2. Passed - bootstrap a controller-0 in an AIODX using a backup as an
    extra argument of "bootstrap_registry_filesystem_fqpn".

    Closes-bug: 2045686
    Signed-off-by: Yuxing Jiang <email address hidden>
    Change-Id: Ie923c6110d1a90d11f0e7ea928374aca75721348