intel-ethernet-operator app fails to upload and apply

[Caio Cesar Ferreira]

Brief Description
-----------------
After uploading the application, the following errors starts to appear:

sysinv 2023-11-16 17:45:33.930 18304 ERROR stevedore.extension [req-19602c23-1015-4589-be61-61c629719512 None None] Could not load '001_intel-ethernet-operator': Can't instantiate abstract class IntelEthernetOperatorHelm with abstract method HELM_RELEASE
sysinv 2023-11-16 17:45:33.931 18304 ERROR stevedore.extension [req-19602c23-1015-4589-be61-61c629719512 None None] Could not load '002_sriov-network-operator': Can't instantiate abstract class SriovNetworkOperatorHelm with abstract method HELM_RELEASE

If tried to apply, it returns apply-failed

Severity
--------
Critical

Steps to Reproduce
------------------
Uploading the application with the command below, return the error on sysinv log.
system application-upload /usr/local/share/applications/helm/intel-ethernet-operator-1.0-5.tgz

Expected Behavior
------------------
After system application-upload the application should return no error and the user must be able to apply the application.

Actual Behavior
----------------
The application uploads, even with the error, then when applied, the sysinv reports error.

Reproducibility
---------------
100%

System Configuration
--------------------
Simplex

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------

Timestamp/Logs
--------------
sysinv 2023-11-16 17:45:31.967 18304 INFO sysinv.conductor.kube_app [-] PluginHelper: Installing intel-ethernet-operator plugin /scratch/apps/intel-ethernet-operator/1.0-5/plugins/k8sapp_intel_ethernet_operator-1.0.5-py2.py3-none-any.whl to /opt/platform/helm/23.09/intel-ethernet-operator/1.0-5/plugins.
sysinv 2023-11-16 17:45:32.038 18304 INFO sysinv.conductor.kube_app [-] Doing FluxCD operation validate with the following manifest: /opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests
sysinv 2023-11-16 17:45:32.890 18304 ERROR sysinv.conductor.kube_app [-] Command: kubectl --kubeconfig /etc/kubernetes/admin.conf apply -k /opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests --dry-run=server; Error: Error from server (NotFound): error when creating "/opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests": namespaces "intel-ethernet-operator" not found
Error from server (NotFound): error when creating "/opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests": namespaces "intel-ethernet-operator" not found
Error from server (NotFound): error when creating "/opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests": namespaces "intel-ethernet-operator" not found
Error from server (NotFound): error when creating "/opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests": namespaces "intel-ethernet-operator" not found
Error from server (NotFound): error when creating "/opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests": namespaces "intel-ethernet-operator" not found
Error from server (NotFound): error when creating "/opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests": namespaces "intel-ethernet-operator" not found
Error from server (NotFound): error when creating "/opt/platform/fluxcd/23.09/intel-ethernet-operator/1.0-5/intel-ethernet-operator-fluxcd-manifests": namespaces "intel-ethernet-operator" not found
sysinv 2023-11-16 17:45:32.987 18304 INFO sysinv.conductor.kube_app [-] Helm chart sriov-network-operator validated
sysinv 2023-11-16 17:45:33.115 18304 INFO sysinv.conductor.kube_app [-] Helm chart intel-ethernet-operator validated
sysinv 2023-11-16 17:45:33.119 18304 INFO sysinv.conductor.kube_app [-] Application intel-ethernet-operator (1.0-5) will load charts to chart repo stx-platform
sysinv 2023-11-16 17:45:33.119 18304 INFO sysinv.conductor.kube_app [-] Application intel-ethernet-operator (1.0-5) will disable charts [] by default
sysinv 2023-11-16 17:45:33.264 18304 WARNING sysinv.conductor.manager [-] Unable to retrigger '949902ef-b452-419d-af7f-295b7aecf3e4' from runtime config history: '949902ef-b452-419d-af7f-295b7aecf3e4'
sysinv 2023-11-16 17:45:33.337 18304 INFO sysinv.conductor.kube_app [-] Helm chart sriov-network-operator-1.2.0.tgz uploaded
sysinv 2023-11-16 17:45:33.557 18304 INFO sysinv.conductor.kube_app [-] Helm chart intel-ethernet-operator-1.0.0.tgz uploaded
sysinv 2023-11-16 17:45:33.580 18304 INFO sysinv.conductor.kube_app [req-19602c23-1015-4589-be61-61c629719512 None None] PluginHelper: Enabled plugin directory /opt/platform/helm/23.09/intel-ethernet-operator/1.0-5/plugins: created /var/stx_app/plugins/stx_app-intel-ethernet-operator-1.0-5.pth
sysinv 2023-11-16 17:45:33.930 18304 ERROR stevedore.extension [req-19602c23-1015-4589-be61-61c629719512 None None] Could not load '001_intel-ethernet-operator': Can't instantiate abstract class IntelEthernetOperatorHelm with abstract method HELM_RELEASE
sysinv 2023-11-16 17:45:33.931 18304 ERROR stevedore.extension [req-19602c23-1015-4589-be61-61c629719512 None None] Could not load '002_sriov-network-operator': Can't instantiate abstract class SriovNetworkOperatorHelm with abstract method HELM_RELEASE

Test Activity
-------------
[Sanity, Feature Testing, Regression Testing, Developer Testing, Evaluation, Other - Please specify]

Workaround
----------
Added the following lines on both intel_ethernet_operator.py and sriov_network_operator.py, build the application, the upload and applied.

    @property
    def CHART(self):
        return app_constants.HELM_CHART_INTEL_ETHERNET_OPERATOR

    def HELM_RELEASE(self):
        return app_constants.HELM_CHART_INTEL_ETHERNET_OPERATOR

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/app-intel-ethernet-operator/+/901206

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/app-intel-ethernet-operator/+/901206
Committed: https://opendev.org/starlingx/app-intel-ethernet-operator/commit/d5cf1358773b3d6db5907a353e303ac66a9620b9
Submitter: "Zuul (22348)"
Branch: master

commit d5cf1358773b3d6db5907a353e303ac66a9620b9
Author: Caio Cesar Ferreira <email address hidden>
Date: Thu Nov 16 17:12:35 2023 -0300

    fix HELM_RELEASE bug on upload app

    This commit fixes HELM_RELEASE abstract method error when the
    application is uploading.

    Closes-Bug: 2043726

    TEST PLAN:
    PASS: Build application
    PASS: SX: Upload the application
    PASS: SX: Apply the application

    Change-Id: Idf0655bc9c9d76eb11984ac4299310167ea699d2
    Signed-off-by: Caio Cesar Ferreira <email address hidden>