DC upgrade: Subcloud failed to activate upgrade with error: unhashable type: 'slice'

[Fabrizio Perez]

Brief Description

DC upgrade: Subcloud failed to activate upgrade with error: unhashable type: 'slice'

error:

+-----------+-------+--------+----------------------------------------------+----------------------------+----------------------------+
| cloud | stage | state | details | started_at | finished_at |
+-----------+-------+--------+----------------------------------------------+----------------------------+----------------------------+
| subcloud7 | 3 | failed | activating upgrade: unhashable type: 'slice' | 2023-11-13 07:20:29.479042 | 2023-11-13 08:05:29.224513 |
+-----------+-------+--------+----------------------------------------------+----------------------------+----------------------------+

2023-11-13 08:04:27.278 3958136 INFO dcmanager.orchestrator.states.base [req-41cf3587-a32d-48ee-b9f4-25deb4be602f - - - - -] Stage: 2, State: activating upgrade, Subcloud: subcloud7, Details: Activation failed, retrying... State=activation-failed
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread [req-41cf3587-a32d-48ee-b9f4-25deb4be602f - - - - -] (upgrade) Failed! Stage: 2, State: activating upgrade, Subcloud: subcloud7: TypeError: unhashable type: 'slice'
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread Traceback (most recent call last):
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread File "/usr/lib/python3/dist-packages/dcmanager/orchestrator/orch_thread.py", line 587, in perform_state_action
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread next_state = state_operator.perform_state_action(strategy_step)
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread File "/usr/lib/python3/dist-packages/dcmanager/orchestrator/states/upgrade/activating.py", line 92, in perform_state_action
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread error_description=error_msg[0:consts.ERROR_DESCRIPTION_LENGTH])
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread TypeError: unhashable type: 'slice'
2023-11-13 08:05:29.223 3958136 ERROR dcmanager.orchestrator.orch_thread
2023-11-13 08:05:31.361 3958136 INFO dcmanager.orchestrator.orch_thread [-] (upgrade) Strategy application has failed.

Note:

    Reproduced on upgrade path

Severity

<Critical: System/Feature is not usable after the defect>

Steps to Reproduce

    deploy SystemController
    import inactive load
    deploy subcloud with inactive load
    manage subcloud
    upgrade subcloud

Expected Behavior

The subcloud should be upgraded successfully

Actual Behavior

The subcloud failed to activate upgrade

Reproducibility

100% reproducible

2 out of 2 attempts

System Configuration

DC

Alarms

no alarms

Test Activity

 Regression Testing

Workaround

No workaround

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/900818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/900818
Committed: https://opendev.org/starlingx/config/commit/c1ed66920cf7005af48a0f523aac6e6b336f4422
Submitter: "Zuul (22348)"
Branch: master

commit c1ed66920cf7005af48a0f523aac6e6b336f4422
Author: fperez <email address hidden>
Date: Mon Nov 13 15:34:51 2023 -0300

    Fix unhashable type: 'slice' error in upgrade

    The previous return type of the function get_upgrade_msg() caused
    issues in the dcmanager orchestrator during subcloud upgrades.

    With this small change, the output value from this function can now
    be read directly without the need for any specific parsing.

    Test Plan:
    PASS: Create an upgrade strategy, force errors, and verify the accessibility of the output from the Systemcontroller.

    Closes-bug: 2043408

    Change-Id: I336014269593c504c566a6a902071c160696992b
    Signed-off-by: fperez <email address hidden>