stx-tools: cengn url config option not working correctly

[Davlet Panech]

Brief Description
-----------------
Setting project.debian_snapshot_base/project.debian_security_snapshot_base to debian archive URLs has no effect. "stx config --upgrade" always resets these values back to CENGN mirror URL.

See also: https://<email address hidden>/message/OV4QX546EZKP3FTHWQLAV2RQSQDLVOFX/

Severity
--------
Minor

Steps to Reproduce
------------------
(1)
stx config --add project.debian_snapshot_base http://snapshot.debian.org/archive/debian
stx config --add project.debian_security_snapshot_base http://snapshot.debian.org/archive/debian-security
stx config --upgrade
(2) Check stx.conf

Expected Behavior
------------------
stx.conf should retain values set by "stx config --add"

Actual Behavior
----------------
URLs are reset to CENGN mirror

Reproducibility
---------------
Reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master/2023-11-06

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
N/A

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/tools/+/900223

[Davlet Panech (dpanech)]

This problem happens only upon 1st execution -- ie after stx.conf has been created for the 1st time.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/900223
Committed: https://opendev.org/starlingx/tools/commit/1f7a760068a909c1f47cc75516ff022facc75da5
Submitter: "Zuul (22348)"
Branch: master

commit 1f7a760068a909c1f47cc75516ff022facc75da5
Author: Davlet Panech <email address hidden>
Date: Mon Nov 6 12:27:11 2023 -0500

    Remove obsolete stx.conf upgrade

    Remove code that automagically changes debian archive URLs in stx.conf
    to public WR mirror URLs. This upgrade was added last year and was only
    relevant to un-upgraded development environments that existed at that
    time (eg on developer desktops). It is no longer relevant. Removing it
    because it breaks the ability of the user to explicitly set those URLs
    to the real Debian archive repository under some circumstances.

    How to reproduce:
    * Remove existing stx.conf
    * Copy stx.conf.example => stx.conf
    * Replace the key:
      stx config --add stx config --add project.debian_snapshot_base http://snapshot.debian.org/archive/debian
    * Upgreade configuration:
      stx config --upgrade
    * ===> URL gets reset back to default (mirror) in stx.conf

    TESTS
    ==================================
    * Re-run above steps and make sure this doesn't happen

    Closes-Bug: 2042854

    Signed-off-by: Davlet Panech <email address hidden>
    Change-Id: I3ff011d747f2804ade0152ad0296b00ba2785ebf