Horizon patch upload fails with 'No file was submitted.

[Wentao Zhang]

When trying to upload a patch file using Horizon menu, it fails with the 'No file was submitted. Check the encoding type on the form' message.

Severity

<Minor: System/Feature is usable with minor issue>

Steps to Reproduce

Log into horizon.

Go to Software Management menu -> Patches tab -> Upload patches button

Press 'Choose files' and select a patch file.

Press Upload Patches.

See the error 'No file was submitted. Check the encoding type on the form.'

Expected Behavior

Patch file is uploaded successfully

Actual Behavior

Menu shows an error message.

Reproducibility

100% Reproducible

System Configuration

All types

Load info (eg: 2022-03-10_20-00-07)

SW_VERSION="23.09"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="2023-10-13_21-45-26"

Last Pass

load from 09/01 works.

Timestamp/Logs

N/A

Alarms

N/A

Test Activity

Developer testing

Workaround

Use CLI.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/gui/+/899998

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/gui/+/899998
Committed: https://opendev.org/starlingx/gui/commit/7ce032a63910990dfcecbc4d81833f4cc0879cc1
Submitter: "Zuul (22348)"
Branch: master

commit 7ce032a63910990dfcecbc4d81833f4cc0879cc1
Author: Wentao Zhang <email address hidden>
Date: Fri Nov 3 11:43:00 2023 +0800

    Fix the problem that patch upload fails of horizon

    https://github.com/django/django/commit/fb4c55d9ec4bb812a7fb91fa20510d91645e411b
    This commit disables FileField for uploading multiple files
    directly and introduces a new method as a replacement.
    the upgrade of python3-django from 2:2.2.28-1~deb11u1 to
    2:2.2.28-1~deb11u2 includes this commit.
    Replace FileField with MultipleFileField for uploading multiple files.
    Refer to the method introduced in the commit to replace
    the previous usage.

    Test Plan
    PASS: build-pkgs -c -p starlingx-dashboard && build-image
    PASS: jenkins installation successfuly
    PASS: upload a patch using Horizon Web interface successfully

    Closes-Bug: 2042610

    Change-Id: I7bb4a0db7621922e5f1c8811ec3f49be4a37d1a5
    Signed-off-by: Wentao Zhang <email address hidden>