100.114 invalid / unreachable ntp alarm alarm for controller-1 on AIO-SX node

[Heron Vieira]

Brief Description
-----------------
AIO-SX node (single host, controller-0), configured with NTP for clock_synchronization, is alerting that controller-1 is "is not a valid or a reachable NTP server".

controller-1 will not be a valid time source as long as the subcloud is an AIO-SX configuration. This alarm makes no sense.

Severity
--------
Minor

Steps to Reproduce
------------------
N/A

Expected Behavior
------------------
No alarm should be raised

Actual Behavior
----------------
Alarm 100.114 is raised

Reproducibility
---------------
Seen once

System Configuration
--------------------
AIO-SX

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/899090
Committed: https://opendev.org/starlingx/stx-puppet/commit/6abe93d451b8457e2709df1a8607c46e61e37e76
Submitter: "Zuul (22348)"
Branch: master

commit 6abe93d451b8457e2709df1a8607c46e61e37e76
Author: Heron Vieira <email address hidden>
Date: Mon Oct 23 15:27:18 2023 -0300

    Remove controller-1 as NTP peer for SX

    Remove controller-1 as NTP peer in a
    SX system, since there's no controller-1
    in a Simplex configuration.

    Test plan
    PASS: AIO-SX install, bootstrap and initial unlock
    PASS: Verify if controller-1 is not configured as NTP peer on SX.
    PASS: AIO-DX install, bootstrap and initial unlock
    PASS: Verify if controller-1 is still configured as NTP peer on DX.
    PASS: Make a AIO-SX to AIO-DX migration and verify if ntp.conf is
        configured correctly after the migration, with the ntp peer
        set to the controller's mate.

    Closes-bug: 2041277

    Change-Id: I2bfcbc5ae2c50bcd6c2aebfef506e6bd3ae831b5
    Signed-off-by: Heron Vieira <email address hidden>