tox/zuul: pylint fails commits pointing to yaml function calls

Bug #2040283 reported by Leonardo Fagundes Luz Serrano
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
High
Leonardo Fagundes Luz Serrano

Bug Description

Brief Description
-----------------

On Oct 23 2023 version 0.18.0 of ruamel.yaml was released and several yaml functions became deprecated,
causing pylint to fail commits on repos which contain the affected functions

Ref:
https://pypi.org/project/ruamel.yaml/0.18.0/

Severity
--------
<Critical: System/Feature is not usable due to the defect>
Commits can't merge

Steps to Reproduce
------------------
Post commit reviews to the affected repos

Expected Behavior
------------------
Commits have their changes evaluated

Actual Behavior
----------------
Any commit on a repo using a deprecated function will fail

Reproducibility
---------------
<Reproducible>

System Configuration
--------------------
NA

Branch/Pull Time/Commit
-----------------------
NA

Last Pass
---------
A couple days ago

Timestamp/Logs
--------------
https://zuul.opendev.org/t/openstack/build/38fa13969f7447da8ecee0156fd7a76a

Test Activity
-------------
Commit review

Workaround
----------
Pin module version as suggested in the ref: ruamel.yaml<0.18.0

Changed in starlingx:
assignee: nobody → Leonardo Fagundes Luz Serrano (lfagunde)
Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/899187

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/c/starlingx/config/+/899187
Committed: https://opendev.org/starlingx/config/commit/4522bacca7133f247d4f90041b1e03b4102802dd
Submitter: "Zuul (22348)"
Branch: master

commit 4522bacca7133f247d4f90041b1e03b4102802dd
Author: Chris Friesen <email address hidden>
Date: Tue Oct 24 09:29:08 2023 -0600

    tox: pin ruamel.yaml version to <0.18.0

    Some functions have become deprecated on 0.18.0 [1],
    such as yaml safe_load() and safe_load_all()

    Pinned the version to allow commits to merge while
    these API calls are updated.

    [1] https://pypi.org/project/ruamel.yaml/0.18.0/

    Test Plan: upload to Zuul and verify it passes

    Partial-Bug: 2040283
    Change-Id: I9f7e33d785f9dce0f465e92ca620e684b396aa8c
    Signed-off-by: Chris Friesen <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (master)

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/899168
Committed: https://opendev.org/starlingx/stx-puppet/commit/b4c1de12a9ccef2771ab85434559bc10e068a5df
Submitter: "Zuul (22348)"
Branch: master

commit b4c1de12a9ccef2771ab85434559bc10e068a5df
Author: Leonardo Fagundes Luz Serrano <email address hidden>
Date: Tue Oct 24 10:20:53 2023 -0300

    tox: Pin ruamel.yaml version to <0.18.0

    Some functions have become deprecated on 0.18.0 [1],
    such as yaml safe_load() and safe_load_all()

    Pinned the version to allow commits to merge while
    these API calls are updated.

    [1] https://pypi.org/project/ruamel.yaml/0.18.0/

    Test Plan:
    pass: tox -epylint -vv --skip-missing-interpreters=false
    pass: tox

    Closes-Bug: 2040283

    Change-Id: I83f1319ea99106be0d3c712c68d2c12d7b9646d9
    Signed-off-by: Leonardo Fagundes Luz Serrano <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → High
tags: added: stx.9.0 stx.zuul
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.