Upgrade fail: 'The conditional check 'create_platform_certificates' failed

[Marcelo de Castro Loebens]

Brief Description
-----------------
The conditional check 'create_platform_certificates' failed. The error was: error while evaluating conditional (create_platform_certificates): 'create_platform_certificates' is undefined

Severity
--------
Critical.

Steps to Reproduce
------------------
Upgrade from stx 8.0 to master branch.

Expected Behavior
------------------
Upgrade should succeed.

Actual Behavior
----------------
Upgrade fails. See logs:

2023-10-12 14:30:25,356 p=2769 u=sysadmin n=ansible | Thursday 12 October 2023 14:30:25 +0000 (0:00:00.019) 0:01:18.694 ******
2023-10-12 14:30:25,371 p=2769 u=sysadmin n=ansible | skipping: [localhost]
2023-10-12 14:30:25,374 p=2769 u=sysadmin n=ansible | TASK [bootstrap/validate-config : Check if the user provided file paths for RCA, ICA cert and ICA key] ***************
2023-10-12 14:30:25,375 p=2769 u=sysadmin n=ansible | Thursday 12 October 2023 14:30:25 +0000 (0:00:00.018) 0:01:18.712 ******
2023-10-12 14:30:25,394 p=2769 u=sysadmin n=ansible | fatal: [localhost]: FAILED! =>
  msg: |-
    The conditional check 'create_platform_certificates' failed. The error was: error while evaluating conditional (create_platform_certificates): 'create_platform_certificates' is undefined

    The error appears to be in '/usr/share/ansible/stx-ansible/playbooks/roles/bootstrap/validate-config/tasks/main.yml': line 818, column 7, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:

        block:
        - name: Check if the user provided file paths for RCA, ICA cert and ICA key
          ^ here
2023-10-12 14:30:25,396 p=2769 u=sysadmin n=ansible | PLAY RECAP ***********************************************************************************************************
2023-10-12 14:30:25,396 p=2769 u=sysadmin n=ansible | localhost : ok=199 changed=50 unreachable=0 failed=1 skipped=237 rescued=0 ignored=0
2023-10-12 14:30:25,396 p=2769 u=sysadmin n=ansible | Thursday 12 October 2023 14:30:25 +0000 (0:00:00.021) 0:01:18.733 ******

Reproducibility
---------------
100%

System Configuration
--------------------
AIO-SX.

Branch/Pull Time/Commit
-----------------------
master.

Last Pass
---------
NA

Timestamp/Logs
--------------
NA

Test Activity
-------------
Developer Testing.

Workaround
----------
NA

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/898682

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/898842

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Marcelo de Castro Loebens <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/898842
Reason: dup

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/898843

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Marcelo de Castro Loebens <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/898843
Reason: dup

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/898682
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/79373b64de059eab06db134758afed30a9bbaf6f
Submitter: "Zuul (22348)"
Branch: master

commit 79373b64de059eab06db134758afed30a9bbaf6f
Author: Marcelo Loebens <email address hidden>
Date: Tue Oct 17 16:21:23 2023 -0400

    Fix undefined variable in upgrade from stx8

    Include missing variable file in upgrade_platform_optimized.yml
    playbook, to fix error where variable 'create_platform_certificates'
    is undefined during upgrades in SX systems.

    Test plan:
    PASS: Upgrade AIO-SX system from stx8 to master + this change.
          Upgrade succeeded pass the original issue, but hit
          another issue related to
          https://review.opendev.org/c/starlingx/ansible-playbooks/+/889902.

    Closes-Bug: 2039600

    Change-Id: I5943b1068d2162e7a8c1bc92553be68cfeaed2df
    Signed-off-by: Marcelo Loebens <email address hidden>