DC rehoming - Subcloud rehoming fail to update smapi attribute

[Yuxing]

Brief Description

DC rehoming - Subcloud rehoming fail to update smapi attribute

Error:

TASK [rehome-subcloud/update-keystone-data : Update keystone passwords] ********
Friday 13 October 2023 19:43:50 +0000 (0:00:00.275) 0:02:57.373 ********
fatal: [subcloud1]: FAILED! =>
  msg: '''dict object'' has no attribute ''smapi'''

-------------------------

smapi does not exist in /var/opt/dc/ansible/subcloud1.yml

root@controller-0:/var/home/sysadmin# cat /var/opt/dc/ansible/subcloud1.yml | grep smapi
root@controller-0:/var/home/sysadmin#

Severity

<Critical: System/Feature is not usable after the defect>

Steps to Reproduce

Upgrade target SystemController
Verify is the target SystemController is able to run playbooks from inactive load
Import --inactive load (this is required to feed 21.12/playbook with 21.12 playbooks, such as rehome playbook)
run subcloud rehoming playbook
Expected Behavior

The subcloud running inactive load should be rehomed successfully

Actual Behavior

The subcloud fails to be rehomed

Reproducibility

100% reproducible

System Configuration

Dc

Load info (eg: 2022-03-10_20-00-07)

cat /etc/build.info
SW_VERSION="22.12"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="2022-12-19_02-22-00"
SRC_BUILD_ID="38"JOB="wrcp-22.12-debian"
BUILD_BY="jenkins"
BUILD_NUMBER="50"
BUILD_HOST="yow-wrcp-lx.wrs.com"
BUILD_DATE="2022-12-19 07:22:00 +0000"
sysadmin@controller-0:~$ sw-patch query
         Patch ID RR Release Patch State
=========================== == ======= ===========
WRCP_21.12_PATCH_0001 Y 21.12 Committed
WRCP_21.12_PATCH_0002 Y 21.12 Committed
WRCP_21.12_PATCH_0003 Y 21.12 Committed
WRCP_21.12_PATCH_0004 Y 21.12 Committed
WRCP_21.12_PATCH_0005 Y 21.12 Committed
WRCP_21.12_PATCH_0006 Y 21.12 Committed
WRCP_21.12_PATCH_0007 Y 21.12 Committed
WRCP_21.12_PATCH_0008 Y 21.12 Committed
WRCP_21.12_PATCH_0009 Y 21.12 Committed
WRCP_21.12_PATCH_0010 N 21.12 Committed
WRCP_21.12_PATCH_0011 Y 21.12 Committed
WRCP_21.12_PATCH_0012 Y 21.12 Committed
WRCP_22.12_PATCH_0001 Y 22.12 Committed
WRCP_22.12_PATCH_0002 Y 22.12 Committed
WRCP_22.12_PATCH_0003_OCT02 Y 22.12 Committed
Last Pass

new test scenario.

Timestamp/Logs

Alarms

no alarms

Test Activity

Feature Testing

Workaround

no workarounds

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/898508

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/898508
Committed: https://opendev.org/starlingx/distcloud/commit/680254d361410e0e207436b234bef4b140b78488
Submitter: "Zuul (22348)"
Branch: master

commit 680254d361410e0e207436b234bef4b140b78488
Author: Yuxing Jiang <email address hidden>
Date: Mon Oct 16 21:01:57 2023 -0400

    Support rehoming a CentOS subcloud to a Debian system controller

    This commit adds the following support for the ansible subcloud
    rehoming playbook from the previous CentOS release, to enable rehoming
    a CentOS subcloud to a Debian system controller:

    1. Exports the smapi password to the subcloud's overrides file
    2. Adds the absolute path of the validate_keystone_password.sh on the
    subcloud to support the playbook to invoke this script in the
    subcloud.

    Test plan:
    1. PASS - Rehome an AIOSX subcloud installed with the same software
    version with the system controllers.
    2. PASS - Rehome an AIOSX subcloud installed with 21.12 version to
    a system controller installed with the master, specifying the
    --release argument with the value of 21.12.

    Closes-bug: 2039507
    Signed-off-by: Yuxing Jiang <email address hidden>
    Change-Id: I24367e88acf6f785827b27daa9d390b188ae423e