/etc/apt/sources.list should be empty.

[Chuck Short]

Brief Description
-----------------
/etc/apt/sources.list contains the servers that is used to build the ISO from. These servers are not available over the network and leaves apt in a broken statue out of the box.

Severity
--------
Minor

Steps to Reproduce
------------------
1. Boot from ISO
2. Loot at the contents of /etc/apt/sources.list.

Expected Behavior
------------------
Apt should only complain that the filesystem is read-only.

Actual Behavior
----------------
Apt complains about the filesystem is read-only and the server is not accessible.

Reproducibility
---------------
Everytime

System Configuration
--------------------
Simplex

Branch/Pull Time/Commit
-----------------------
Master

Last Pass
---------
Never

Test Activity
-------------
Feature testing for apt-ostree.

Workaround
----------
cat /dev/null > /etc/apt/sources.list

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/tools/+/894552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/894552
Committed: https://opendev.org/starlingx/tools/commit/cfceeba1272604a1eb7e317e560844e7c0309699
Submitter: "Zuul (22348)"
Branch: master

commit cfceeba1272604a1eb7e317e560844e7c0309699
Author: Charles Short <email address hidden>
Date: Mon Sep 11 11:59:32 2023 -0400

    debian: /etc/apt/sources.list should be empty

    LAT configures the ISO with the apt repositories from
    the aptly repositories, which is the correct behaviour.
    But it does not clean up after itself and leaves
    the /etc/apt/sources.list as is when the build is complete.

    Leaving the /etc/apt/sources.list as is will not allow
    apt-ostree to install Debian packages via apt.

    Test Plan:
    1. Build and Install ISO.
    2. Check the contents of /etc/apt/sources.list.
    3. After patch is applied the contants of /etc/apt/sources.list
       should be empty.

    Closes-Bug: 2035121

    Change-Id: If3bfcbcfc4e11f42d568602e539d40154778c9bc
    Signed-off-by: Charles Short <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/898224
Committed: https://opendev.org/starlingx/tools/commit/5dbdb7119a4ad261b2760b0d3dfd58abc13acac8
Submitter: "Zuul (22348)"
Branch: master

commit 5dbdb7119a4ad261b2760b0d3dfd58abc13acac8
Author: Charles Short <email address hidden>
Date: Mon Sep 11 11:59:32 2023 -0400

    Additional Apt-ostree build tool fixes

    LAT configures the ISO with the apt repositories from
    the aptly repositories, which is the correct behaviour.
    But it does not clean up after itself and leaves
    the /etc/apt/sources.list as is when the build is complete.

    Leaving the /etc/apt/sources.list as is will not allow
    apt-ostree to install Debian packages via apt.

    Also add the following Debian packages because they
    are now build depenencies for apt-ostree:

    - gir1.2-packagekitglib-1.0
    - libpackagekit-glib2-18
    - python3-pycurl
    - python3-software-properties
    - python3-systemd

    Test Plan:
    1. Build and Install ISO.
    2. Check the contents of /etc/apt/sources.list, the file
       should be empty.

    Closes-Bug: 2035121

    Change-Id: Ic19f786aa62b769058fedd2568692baeeddfee2b
    Signed-off-by: Charles Short <email address hidden>