Subcloud prestage: Old version of miniboot.cfg is looking for prestaged data in a wrong directory

[srana]

Brief Description
-----------------
Subcloud prestage: Kickstart.cfg is looking for prestaged data in a wrong directory

Error: (Install logs does not go through the task to retrieve prestage data)

prestage data on subcloud side:
ls /opt/platform-backup/22.12/ | grep ostree
ostree_repo

kickstart file: /var/www/pages/feed/rel-22.12/kickstart/miniboot.cfg

backup_mount=/tmp/platform-backup

 if [ -e ${backup_mount}/ostree_repo ]; then

Note:

The conditional above should include sw_release,
if [ -e ${backup_mount}/22.12/ostree_repo ]; then

Severity
--------
<Critical: System/Feature is not usable after the defect>

Steps to Reproduce
------------------
deploy subcloud

prestage subcloud

re-install subcloud

Expected Behavior
------------------
reinstall process should retrieve prestaged data from local

Actual Behavior
----------------
the kickstart script is looking for the prestaged data in a wrong location

Reproducibility
---------------
100%

System Configuration
--------------------
DC / subcloud

Branch/Pull Time/Commit
-----------------------
master (31/08/2023)

Last Pass
---------
new test scenario

Timestamp/Logs
--------------
not collected

the kickstart script already points the issue root cause by itself

Test Activity
-------------
Feature Testing

Workaround
----------
Describe workaround if available

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/894224
Committed: https://opendev.org/starlingx/metal/commit/0366f8552d5ac9784de9992b6ae98958c9a40381
Submitter: "Zuul (22348)"
Branch: master

commit 0366f8552d5ac9784de9992b6ae98958c9a40381
Author: Salman Rana <email address hidden>
Date: Thu Sep 7 16:11:29 2023 -0400

    Fix kickstarts patching

    Ostree doesn't manage the /var filesystem. Anything
    installed there during initial filesystem setup becomes
    unpatchable [1]. As a result, the kickstart install dir
    /var/www/pages/feed/rel-${platform_release}/kickstart
    is not updated according to patch changes.

    This commit changes the platform-kickstarts install paths
    to a place that ostree handles,
    /usr/share/platform-kickstarts/rel-${platform_release}
    in this case and symlinks it to
    /var/www/pages/feed/rel-${platform_release}/kickstarts.

    [1] https://review.opendev.org/c/starlingx/ha/+/890918

    Test Plan:
    1. PASS: ISO install and verify symlink created:
             /var/www/pages/feed/rel-${platform_release}/kickstarts ->
             /usr/share/platform-kickstarts/rel-${platform_release}
    2. PASS: Verify that the centos/ dir, kickstart.cfg & miniboot.cfg
             are installed to /usr/share/platform-kickstarts/
             rel-${platform_release}
    3. PASS: Verify PATCH apply, ensure that changes are applied to
             /var/www/pages/feed/rel-${platform_release}/kickstarts
    4. PASS: Manually remove/re-install the platform-kickstarts package
             and verify kickstarts dir and symlink

    Closes-Bug: 2034753
    Closes-Bug: 2035109

    Change-Id: I307d28c086bb3d9f0e4d6792db44e55c99358a50
    Signed-off-by: Salman Rana <email address hidden>

[Ghada Khalil (gkhalil)]

This code change introduced a sanity issue was reported in https://bugs.launchpad.net/starlingx/+bug/2037545

A revert has been merged:
https://review.opendev.org/c/starlingx/metal/+/896525

Re-opening this LP as the original fix will need to be re-worked.