Cluster VIP is brought up twice during restore

[Joshua Kraitberg]

Brief Description
-----------------
Cluster VIP is already up, so the playbook fails when it tries to bring it up a second time.

Severity
--------
Critical

Steps to Reproduce
------------------
Performed a backup on an SX lab.
Reinstalled the controller and loaded the image.
Ran the restore ansible playbook and used the optimized flag and passed the backup files taken previously.

Expected Behavior
------------------
Restore pass

Actual Behavior
----------------
Restore failed:
E TASK [optimized-restore/restore-data : Configure controller host addresses] ****
E Wednesday 06 September 2023 16:53:30 +0000 (0:00:05.401) 0:05:54.385 ***
E fatal: [localhost]: FAILED! => changed=true
E cmd:
E - ip
E - addr
E - add
E - aefd::1
E - dev
E - lo
E - scope
E - host
E delta: '0:00:00.001954'
E end: '2023-09-06 16:53:30.949480'
E msg: non-zero return code
E rc: 2
E start: '2023-09-06 16:53:30.947526'
E stderr: 'RTNETLINK answers: File exists'
E stderr_lines: <omitted>
E stdout: ''
E stdout_lines: <omitted>

Reproducibility
---------------
Once

System Configuration
--------------------
AIO-SX

Branch/Pull Time/Commit
-----------------------
SW_VERSION="23.09"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="2023-09-01_18-00-09"
SRC_BUILD_ID="1266"

Last Pass
---------
2023-08-24_18-00-10

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Regression Testing

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/893979
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/9687c095baef2d203489f0cf9e86c4612fe03377
Submitter: "Zuul (22348)"
Branch: master

commit 9687c095baef2d203489f0cf9e86c4612fe03377
Author: Joshua Kraitberg <email address hidden>
Date: Wed Sep 6 16:31:54 2023 -0400

    Fix: Do not bring up Host floating IP (VIP) twice

    On certain system configurations, cluster VIP will already be brought
    up. If the playbook attempts to bring it up a
    second time there will be an error.

    This can potentially occur during optimized restore or
    Debian to Debian AIO-SX upgrades. When the cluster-host-subnet's
    floating IP is configured to be on the lo interface as
    shown in `system addrpool-list`.

    The second attempt now checks to ensure the address is not up already.

    TEST PLAN
    PASS: Optimized B&R on AIO-SX
    * Run on affected system,
    * Run on unaffected system
    PASS: Upgrade stx6 to stx8 on AIO-SX
    PASS: Optimized B&R on AIO-SX after stx6 to stx8 upgrade

    Closes-Bug: 2034616
    Signed-off-by: Joshua Kraitberg <email address hidden>
    Change-Id: I60cdcbc4fcf20dddf11a9af7dba8b4031ed006f8