Subcloud backup creation failure removes custom local backup directory

[Gustavo Lyra Pereira]

Brief Description
-----------------
Custom backup directory stored in subcloud is removed in case of a backup creation failure due
to lack of space.

Severity
--------
Minor: System/Feature is usable with minor issue.

Steps to Reproduce
------------------
Backup subcloud.
Make sure the storage FS runs out of available space.
Backup subcloud (expected failure).

Expected Behavior
------------------
The backup create should fail and the existing backups should not be deleted.

Actual Behavior
----------------
The existing backup are deleted.

Reproducibility
---------------
100% reproducible.

System Configuration
--------------------
DC

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Evaluation.

Workaround
----------
No workarounds found.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/893686

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/893686
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/1c782df1ea7ae468328f154ff35948772342e144
Submitter: "Zuul (22348)"
Branch: master

commit 1c782df1ea7ae468328f154ff35948772342e144
Author: Gustavo Pereira <email address hidden>
Date: Mon Sep 4 15:47:55 2023 -0300

    Subcloud backup failure removes custom backup directory

    This commit fixes the issue of deleting the custom
    backup directory defined in the overrides file and
    stored on a subcloud when the backup creation
    process fails.

    Test Plan:

    PASS - Deploy a subcloud and create an override backup
    file with a custom backup directory defined. Take a
    subcloud backup passing the --local-only parameter
    to store the backup in the subcloud. Create a custom
    file with the same size of the remaining available
    space in the custom backup directory. Take another
    backup. Verify that the previous backup was not
    removed when the backup creation failed due to a
    lack of space.

    PASS - Deploy a subcloud and create an override backup
    file with a custom backup directory defined. Take a
    subcloud backup and create a custom file with the same
    size of the remaining available space in the custom
    backup directory. Take another backup and verify
    that the previous backup was not removed when the
    backup creation failed due to a lack of space.

    Closes-bug: 2033529

    Signed-off-by: Gustavo Pereira <email address hidden>
    Change-Id: I82c3f6cb82d1947aa617e4202b5449abfc0bf735